https://bugzilla.redhat.com/show_bug.cgi?id=1919639
Otto Urpelainen <oturpe(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(robert.de.rooy@gm
| |ail.com)
--- Comment #28 from Otto Urpelainen <oturpe(a)iki.fi> ---
Great, the items from previous batch are now all resolved. Here are two more:
- This would be better with %{_sbindir} macro here instead of hard coded
/usr/sbin. Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
if [ -x /usr/sbin/setcap ]; then
- Man page should be installed. I see that you have added it upstream, is it
just accidentally missing from %install? Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
I only have a couple of items remaining, the big two being:
1. Licenses, already discussed before. I will attach the list of licenses
fedora-review found; there is more than GPLv2+ even if vs2015 is not counted.
Could you check that and find out, what actually should be written to License
field, following
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
This will be easier if the source rpm minification is done first, because there
will be less clutter from unused files.
2. Bundled dependencies. To me, src/libs looks like collection of bundled
libraries. Could you check the content of src/libs against guidelines at
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling and
comment?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component