https://bugzilla.redhat.com/show_bug.cgi?id=1420099
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> ---
I think removing the bad-licensed tests in %prep is too late as they are still
distributed in the SRPM package, but I believe you know what you do.
Mail::Transfer is not needed. Ok.
All tests pass. Ok.
$ rpmlint perl-Mail-Message.spec
../SRPMS/perl-Mail-Message-3.000-2.fc26.src.rpm
../RPMS/noarch/perl-Mail-Message-3.000-2.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Mail-Message-3.000-2.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.1)
1 perl(:VERSION) >= 5.7.3
1 perl(base)
1 perl(Carp)
1 perl(Cwd)
1 perl(Date::Format)
1 perl(Email::Simple)
1 perl(Encode)
1 perl(Encode::Alias)
1 perl(Exporter)
1 perl(File::Basename)
1 perl(File::Copy)
1 perl(File::Spec)
1 perl(File::Temp)
1 perl(HTML::FormatText)
1 perl(HTML::TreeBuilder)
1 perl(integer)
1 perl(IO::File)
1 perl(IO::Handle)
1 perl(IO::Lines)
1 perl(List::Util)
1 perl(Mail::Address)
1 perl(Mail::Box::FastScalar)
1 perl(Mail::Box::Parser)
1 perl(Mail::Box::Parser::Perl)
1 perl(Mail::Header)
1 perl(Mail::Identity)
1 perl(Mail::Internet)
1 perl(Mail::Message)
1 perl(Mail::Message::Body)
1 perl(Mail::Message::Body::File)
1 perl(Mail::Message::Body::Lines)
1 perl(Mail::Message::Body::Multipart)
1 perl(Mail::Message::Body::Nested)
1 perl(Mail::Message::Body::String)
1 perl(Mail::Message::Construct)
1 perl(Mail::Message::Convert)
1 perl(Mail::Message::Field)
1 perl(Mail::Message::Field::Address)
1 perl(Mail::Message::Field::Addresses)
1 perl(Mail::Message::Field::AddrGroup)
1 perl(Mail::Message::Field::Attribute)
1 perl(Mail::Message::Field::Date)
1 perl(Mail::Message::Field::Fast)
1 perl(Mail::Message::Field::Full)
1 perl(Mail::Message::Field::Structured)
1 perl(Mail::Message::Field::Unstructured)
1 perl(Mail::Message::Field::URIs)
1 perl(Mail::Message::Head)
1 perl(Mail::Message::Head::Complete)
1 perl(Mail::Message::Head::FieldGroup)
1 perl(Mail::Message::Head::Partial)
1 perl(Mail::Message::Part)
1 perl(Mail::Message::TransferEnc)
1 perl(Mail::Reporter)
1 perl(MIME::Base64)
1 perl(MIME::Entity)
1 perl(MIME::Parser)
1 perl(MIME::QuotedPrint)
1 perl(MIME::Types)
1 perl(overload)
1 perl(POSIX)
1 perl(Scalar::Util)
1 perl(Storable)
1 perl(strict)
1 perl(Sys::Hostname)
1 perl(Test::More)
1 perl(Text::Autoformat)
1 perl(URI)
1 perl(User::Identity::Collection::Emails)
1 perl(utf8)
1 perl(vars)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(Date::Parse)' (lib/Mail/Message/Field.pm:329).
FIX: Run-require `perl(Mail::Transport::Send)' (lib/Mail/Message.pm:164).
FIX: Run-require `perl(Time::Zone)' (lib/Mail/Message/Field.pm:296).
TODO: Remove the __requires_exclude for Mail::SpamAssassin. The dependency is
not autogenerated.
$ rpm -q --provides -p ../RPMS/noarch/perl-Mail-Message-3.000-2.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(Mail::Box::FastScalar) = 3.000
1 perl(Mail::Box::Parser) = 3.000
1 perl(Mail::Box::Parser::Perl) = 3.000
1 perl(Mail::Message) = 3.000
1 perl(Mail::Message::Body) = 3.000
1 perl(Mail::Message::Body::Construct) = 3.000
1 perl(Mail::Message::Body::File) = 3.000
1 perl(Mail::Message::Body::Lines) = 3.000
1 perl(Mail::Message::Body::Multipart) = 3.000
1 perl(Mail::Message::Body::Nested) = 3.000
1 perl(Mail::Message::Body::String) = 3.000
1 perl(Mail::Message::Construct) = 3.000
1 perl(Mail::Message::Construct::Bounce) = 3.000
1 perl(Mail::Message::Construct::Build) = 3.000
1 perl(Mail::Message::Construct::Forward) = 3.000
1 perl(Mail::Message::Construct::Read) = 3.000
1 perl(Mail::Message::Construct::Rebuild) = 3.000
1 perl(Mail::Message::Construct::Reply) = 3.000
1 perl(Mail::Message::Construct::Text) = 3.000
1 perl(Mail::Message::Convert) = 3.000
1 perl(Mail::Message::Convert::EmailSimple) = 3.000
1 perl(Mail::Message::Convert::Html) = 3.000
1 perl(Mail::Message::Convert::HtmlFormatPS) = 3.000
1 perl(Mail::Message::Convert::HtmlFormatText) = 3.000
1 perl(Mail::Message::Convert::MailInternet) = 3.000
1 perl(Mail::Message::Convert::MimeEntity) = 3.000
1 perl(Mail::Message::Convert::TextAutoformat) = 3.000
1 perl(Mail::Message::Field) = 3.000
1 perl(Mail::Message::Field::Address) = 3.000
1 perl(Mail::Message::Field::Addresses) = 3.000
1 perl(Mail::Message::Field::AddrGroup) = 3.000
1 perl(Mail::Message::Field::Attribute) = 3.000
1 perl(Mail::Message::Field::Date) = 3.000
1 perl(Mail::Message::Field::Fast) = 3.000
1 perl(Mail::Message::Field::Flex) = 3.000
1 perl(Mail::Message::Field::Full) = 3.000
1 perl(Mail::Message::Field::Structured) = 3.000
1 perl(Mail::Message::Field::Unstructured) = 3.000
1 perl(Mail::Message::Field::URIs) = 3.000
1 perl(Mail::Message::Head) = 3.000
1 perl(Mail::Message::Head::Complete) = 3.000
1 perl(Mail::Message::Head::FieldGroup) = 3.000
1 perl(Mail::Message::Head::ListGroup) = 3.000
1 perl(Mail::Message::Head::Partial) = 3.000
1 perl(Mail::Message::Head::ResentGroup) = 3.000
1 perl(Mail::Message::Head::SpamGroup) = 3.000
1 perl(Mail::Message::Part) = 3.000
1 perl(Mail::Message::Replace::MailHeader) = 3.000
1 perl(Mail::Message::Replace::MailInternet) = 3.000
1 perl(Mail::Message::Test) = 3.000
1 perl(Mail::Message::TransferEnc) = 3.000
1 perl(Mail::Message::TransferEnc::Base64) = 3.000
1 perl(Mail::Message::TransferEnc::Binary) = 3.000
1 perl(Mail::Message::TransferEnc::EightBit) = 3.000
1 perl(Mail::Message::TransferEnc::QuotedPrint) = 3.000
1 perl(Mail::Message::TransferEnc::SevenBit) = 3.000
1 perl(Mail::Reporter) = 3.000
1 perl-Mail-Message = 3.000-2.fc26
Binary provides are Ok.
Notice: The Mail::Message::*Construct* provides are not found because
generators work on file content and there is no Perl module declared with the
name (`package' keyword). Those identifiers are used for loading by a file
name. Declaring the provides explicitly is fine.
$ resolvedeps rawhide ../RPMS/noarch/perl-Mail-Message-3.000-2.fc26.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F26
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=17686373). OK.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all the `FIX' items and consider fixing `TODO' items before
building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component