https://bugzilla.redhat.com/show_bug.cgi?id=1208695
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #19 from Petr Pisar <ppisar(a)redhat.com> ---
FIX: The spec file has forbidden name
<
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...;.
Rename it to liberasurecode.spec. I believe this was only a mistake as previous
SRPMs contain correct spec file name.
Spec file changes:
--- liberasurecode.spec.old 2015-09-14 10:07:55.135000000 +0200
+++ liberasurecode.spec 2015-09-17 10:54:14.158000000 +0200
@@ -1,12 +1,10 @@
Name: liberasurecode
Version: 1.0.9
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Erasure Code API library written in C with pluggable backends
-# This is a 2-clause BSD with clause numbers edited out for some reason.
-# The src/utils/chksum/md5.c is under CRC32 license, but it's subsumed
-# into the BSD-licensed distribution (see README.md).
-License: BSD
+# Main license is a 2-clause BSD with clause numbers removed for some reason.
+License: BSD and CRC32
URL:
https://bitbucket.org/tsg-/liberasurecode/
# Bitbucket's web export naming is like the old github (== awful), so we pull
# the tag using git CLI. Save the current command for Source0 below.
@@ -16,8 +14,13 @@
BuildRequires: autoconf
BuildRequires: automake
-BuildRequires: libtool
+BuildRequires: coreutils
BuildRequires: doxygen
+BuildRequires: findutils
+BuildRequires: gcc
+BuildRequires: libtool
+BuildRequires: make
+BuildRequires: sed
%description
An API library for Erasure Code, written in C. It provides a number
@@ -32,6 +35,7 @@
%package devel
Summary: Development files for %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: gcc
%description devel
The %{name}-devel package contains libraries and header files for
@@ -54,6 +58,7 @@
%install
%make_install
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
+find $RPM_BUILD_ROOT%{_datadir}/doc -type f -exec chmod a-x {} ';'
%post -p /sbin/ldconfig
@@ -62,7 +67,7 @@
%files
%license COPYING
-%doc README.md
+%doc AUTHORS ChangeLog README.md
%{_libdir}/*.so.*
%files doc
@@ -74,6 +79,9 @@
%changelog
+* Tue Sep 15 2015 Pete Zaitcev <zaitcev(a)redhat.com> 1.0.9-2
+- Address review comments (#1208695)
+
* Fri Sep 11 2015 Pete Zaitcev <zaitcev(a)redhat.com> 1.0.9-1
- Release 1.0.9: true plug-in architecture
TODO: Fix the license comment:
> # The src/utils/chksum/md5.c is under CRC32 license
src/utils/chksum/crc32.c
should be there.
TODO: Add `CRC32' identifier to the License tag.
-# This is
a 2-clause BSD with clause numbers edited out for some reason.
-# The src/utils/chksum/md5.c is under CRC32 license, but it's subsumed
-# into the BSD-licensed distribution (see README.md).
-License: BSD
+# Main license is a 2-clause BSD with clause numbers removed for some reason.
+License: BSD and CRC32
Ok.
FIX: Build-require `sed' (liberasurecode.spec:47).
+BuildRequires: sed
Ok.
FIX: Build-require `make' (liberasurecode.spec:49).
+BuildRequires: make
Ok.
FIX: Build-require `findutils' (liberasurecode.spec:56).
+BuildRequires: findutils
Ok.
FIX: Build-require `coreutils' (liberasurecode.spec:56).
+BuildRequires: coreutils
Ok.
FIX: Build-require `gcc' for including standard library header
files.
+BuildRequires: gcc
Ok.
TODO: Run tests.
The "make test" crashes,
but I reported it upstream and Kevin had it fixed (a double-free) for 1.0.10.
TODO:
I recommend drop a comment into the spec file in order not to forget to
enable the tests when upgrading the package.
TODO: Package AUTHORS and ChangeLog files.
-%doc README.md
+%doc AUTHORS ChangeLog README.md
Ok.
$ rpmlint liberasurecode.spec ../SRPMS/liberasurecode-1.0.9-2.fc24.src.rpm
../RPMS/x86_64/liberasurecode-*
liberasurecode.spec: W: invalid-url Source0: liberasurecode-1.0.9.tar.gz
liberasurecode.src: W: invalid-license CRC32
liberasurecode.src: W: invalid-url Source0: liberasurecode-1.0.9.tar.gz
liberasurecode.x86_64: W: invalid-license CRC32
liberasurecode-debuginfo.x86_64: W: invalid-license CRC32
liberasurecode-devel.x86_64: W: invalid-license CRC32
liberasurecode-devel.x86_64: W: only-non-binary-in-usr-lib
liberasurecode-devel.x86_64: W: no-documentation
liberasurecode-doc.x86_64: W: invalid-license CRC32
5 packages and 1 specfiles checked; 0 errors, 9 warnings.
rpmlint is Ok.
Package builds in F24
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=11119976). Ok.
FIX: Remove executable bits from the liberasurecode-doc files.
$ rpm -q -lv -p ../RPMS/x86_64/liberasurecode-doc-1.0.9-2.fc24.x86_64.rpm
-rw-r--r-- 1 root root 5702 Sep 17 11:02
/usr/share/doc/liberasurecode/html/annotated.html
-rw-r--r-- 1 root root 246 Sep 17 11:02
/usr/share/doc/liberasurecode/html/arrowdown.png
-rw-r--r-- 1 root root 229 Sep 17 11:02
/usr/share/doc/liberasurecode/html/arrowright.png
-rw-r--r-- 1 root root 676 Sep 17 11:02
/usr/share/doc/liberasurecode/html/bc_s.png
-rw-r--r-- 1 root root 147 Sep 17 11:02
/usr/share/doc/liberasurecode/html/bdwn.png
-rw-r--r-- 1 root root 5049 Sep 17 11:02
/usr/share/doc/liberasurecode/html/classes.html
-rw-r--r-- 1 root root 132 Sep 17 11:02
/usr/share/doc/liberasurecode/html/closed.png
-rw-r--r-- 1 root root 4441 Sep 17 11:02
/usr/share/doc/liberasurecode/html/dir_85e1485977b1b5c7656625e6aef9fae5.html
-rw-r--r-- 1 root root 4155 Sep 17 11:02
/usr/share/doc/liberasurecode/html/dir_d44c64559bbebec7f509842c48db8b23.html
-rw-r--r-- 1 root root 746 Sep 17 11:02
/usr/share/doc/liberasurecode/html/doc.png
-rw-r--r-- 1 root root 25495 Sep 17 11:02
/usr/share/doc/liberasurecode/html/doxygen.css
-rw-r--r-- 1 root root 3779 Sep 17 11:02
/usr/share/doc/liberasurecode/html/doxygen.png
-rw-r--r-- 1 root root 3140 Sep 17 11:02
/usr/share/doc/liberasurecode/html/dynsections.js
-rw-r--r-- 1 root root 616 Sep 17 11:02
/usr/share/doc/liberasurecode/html/folderclosed.png
-rw-r--r-- 1 root root 597 Sep 17 11:02
/usr/share/doc/liberasurecode/html/folderopen.png
-rw-r--r-- 1 root root 4335 Sep 17 11:02
/usr/share/doc/liberasurecode/html/functions.html
-rw-r--r-- 1 root root 4207 Sep 17 11:02
/usr/share/doc/liberasurecode/html/functions_vars.html
-rw-r--r-- 1 root root 3514 Sep 17 11:02
/usr/share/doc/liberasurecode/html/index.html
-rw-r--r-- 1 root root 146338 Sep 17 11:02
/usr/share/doc/liberasurecode/html/jquery.js
-rw-r--r-- 1 root root 153 Sep 17 11:02
/usr/share/doc/liberasurecode/html/nav_f.png
-rw-r--r-- 1 root root 95 Sep 17 11:02
/usr/share/doc/liberasurecode/html/nav_g.png
-rw-r--r-- 1 root root 98 Sep 17 11:02
/usr/share/doc/liberasurecode/html/nav_h.png
-rw-r--r-- 1 root root 123 Sep 17 11:02
/usr/share/doc/liberasurecode/html/open.png
-rw-r--r-- 1 root root 314 Sep 17 11:02
/usr/share/doc/liberasurecode/html/splitbar.png
-rw-r--r-- 1 root root 5185 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__args.html
-rw-r--r-- 1 root root 3967 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__backend.html
-rw-r--r-- 1 root root 3977 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__backend__args.html
-rw-r--r-- 1 root root 3981 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__backend__common.html
-rw-r--r-- 1 root root 3977 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__backend__desc.html
-rw-r--r-- 1 root root 4933 Sep 17 11:02
/usr/share/doc/liberasurecode/html/structec__backend__op__stubs.html
-rw-r--r-- 1 root root 853 Sep 17 11:02
/usr/share/doc/liberasurecode/html/sync_off.png
-rw-r--r-- 1 root root 845 Sep 17 11:02
/usr/share/doc/liberasurecode/html/sync_on.png
-rw-r--r-- 1 root root 142 Sep 17 11:02
/usr/share/doc/liberasurecode/html/tab_a.png
-rw-r--r-- 1 root root 169 Sep 17 11:02
/usr/share/doc/liberasurecode/html/tab_b.png
-rw-r--r-- 1 root root 177 Sep 17 11:02
/usr/share/doc/liberasurecode/html/tab_h.png
-rw-r--r-- 1 root root 184 Sep 17 11:02
/usr/share/doc/liberasurecode/html/tab_s.png
-rw-r--r-- 1 root root 1163 Sep 17 11:02
/usr/share/doc/liberasurecode/html/tabs.css
File permissions are Ok.
FIX: Run-require `gcc' by liberasurecode-devel
(/usr/include/liberasurecode/erasurecode_stdinc.h includes standard library
headers).
$ rpm -q --requires -p
../RPMS/x86_64/liberasurecode-devel-1.0.9-2.fc24.x86_64.rpm | sort -f | uniq -c
1 gcc
1 liberasurecode(x86-64) = 1.0.9-2.fc24
1 liberasurecode.so.1()(64bit)
1 liberasurecode_rs_vand.so.1()(64bit)
1 libnullcode.so.1()(64bit)
1 libXorcode.so.1()(64bit)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/liberasurecode-*
Binary dependencies resolvable. Ok.
Except the spec file name, the package is good.
Please correct all FIX items and consider fixing TODO items before building the
package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component