https://bugzilla.redhat.com/show_bug.cgi?id=2117772
Alessio alciregi@posteo.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alciregi@posteo.n | |et) |
--- Comment #4 from Alessio alciregi@posteo.net --- First of all, thank you.
(In reply to Jonathan Wright from comment #3)
Comments
- Add `COPYING` to %license
OK
- I'd personally remove the old changelog that never made it into Fedora.
Just start it with yours.
OK
- `INSTALL` should not be packaged as documentation -
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
Yep.
- You need to add a %check section. Upstream includes tests so we need to
run them. A few of them will fail inside of mock and will need to be excluded but we should run what we can. I did this with a simple section like this between %build and %install:
%check make check
The point is also that the tool should run as privileged users. So, while i.e. sudo ./tests/sanity works, ./tests/sanity doesn't I will exclude all the failing ones. Could be ok?
- This looks like a super handy tool. Please package it for epel8 and
epel9 once approved ;) It builds on both.
Sure.