https://bugzilla.redhat.com/show_bug.cgi?id=1085612
Mihkel Vain turakas@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |turakas@gmail.com
--- Comment #7 from Mihkel Vain turakas@gmail.com --- Hi. This is not a formal review... just some remarks.
1. voxelands.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 3)
Use on only tabs or spaces in spec file.
2. Group: Amusements/Games
You don't need that, unless to plan to target EPEL 5
3. URL: http://wwww.voxelands.com
Loose one w
4. cmake -DBUILD_SERVER=0 -DRUN_IN_PLACE=0 -DCMAKE_INSTALL_PREFIX=/usr
Use %cmake macro eg: %cmake -DBUILD_SERVER=0 -DRUN_IN_PLACE=0 -DCMAKE_INSTALL_PREFIX=/usr
5. %clean rm -rf %{buildroot}
You don't need that, unless to plan to target EPEL 5
5. %defattr(-,root,root)
You don't need that.
Note. This list may not be complete and I don't intend to do formal review, because I think I don't have enough right for this.