https://bugzilla.redhat.com/show_bug.cgi?id=1640819
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
7e51765d39ca6585b67c0832a6101f87b09b3535fb06d6ffeeec68b7c8eacae3) is original.
Ok.
Summary verified from lib/Wiki/Toolkit.pm. Ok.
Description verified from lib/Wiki/Toolkit.pm. Ok.
License verified from lib/Wiki/Toolkit.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
$ rpmlint perl-Wiki-Toolkit.spec
review-perl-Wiki-Toolkit/results/perl-Wiki-Toolkit-0.85-1.fc30.noarch.rpm
review-perl-Wiki-Toolkit/results/perl-Wiki-Toolkit-0.85-1.fc30.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p perl-Wiki-Toolkit-0.85-1.fc30.noarch.rpm
-rwxr-xr-x 1 root root 4450 oct. 19 21:27
/usr/bin/wiki-toolkit-delete-node
-rwxr-xr-x 1 root root 3807 oct. 19 21:27
/usr/bin/wiki-toolkit-rename-node
-rwxr-xr-x 1 root root 5505 oct. 19 21:27
/usr/bin/wiki-toolkit-revert-to-date
-rwxr-xr-x 1 root root 3372 oct. 19 21:27
/usr/bin/wiki-toolkit-setupdb
drwxr-xr-x 2 root root 0 oct. 19 21:28
/usr/share/doc/perl-Wiki-Toolkit
-rw-r--r-- 1 root root 24859 déc. 16 2016
/usr/share/doc/perl-Wiki-Toolkit/Changes
-rw-r--r-- 1 root root 2828 déc. 16 2016
/usr/share/doc/perl-Wiki-Toolkit/README
-rw-r--r-- 1 root root 1764 oct. 19 21:27
/usr/share/man/man1/wiki-toolkit-delete-node.1.gz
-rw-r--r-- 1 root root 1793 oct. 19 21:27
/usr/share/man/man1/wiki-toolkit-rename-node.1.gz
-rw-r--r-- 1 root root 1866 oct. 19 21:27
/usr/share/man/man1/wiki-toolkit-revert-to-date.1.gz
-rw-r--r-- 1 root root 1879 oct. 19 21:27
/usr/share/man/man1/wiki-toolkit-setupdb.1.gz
-rw-r--r-- 1 root root 9111 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit.3pm.gz
-rw-r--r-- 1 root root 3228 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Extending.3pm.gz
-rw-r--r-- 1 root root 3461 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Feed::Atom.3pm.gz
-rw-r--r-- 1 root root 2194 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Feed::Listing.3pm.gz
-rw-r--r-- 1 root root 3801 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Feed::RSS.3pm.gz
-rw-r--r-- 1 root root 2101 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Formatter::Default.3pm.gz
-rw-r--r-- 1 root root 2375 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Formatter::Multiple.3pm.gz
-rw-r--r-- 1 root root 1649 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Formatter::WikiLinkFormatterParent.3pm.gz
-rw-r--r-- 1 root root 2749 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Plugin.3pm.gz
-rw-r--r-- 1 root root 2777 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Search::Base.3pm.gz
-rw-r--r-- 1 root root 1513 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Search::DBIxFTS.3pm.gz
-rw-r--r-- 1 root root 2458 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Search::Lucy.3pm.gz
-rw-r--r-- 1 root root 1709 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Search::Plucene.3pm.gz
-rw-r--r-- 1 root root 1564 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Search::SII.3pm.gz
-rw-r--r-- 1 root root 1681 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::DBIxFTSMySQL.3pm.gz
-rw-r--r-- 1 root root 1139 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::Database.3pm.gz
-rw-r--r-- 1 root root 2242 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::MySQL.3pm.gz
-rw-r--r-- 1 root root 2230 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::Pg.3pm.gz
-rw-r--r-- 1 root root 1755 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::SII.3pm.gz
-rw-r--r-- 1 root root 2167 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Setup::SQLite.3pm.gz
-rw-r--r-- 1 root root 7010 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Store::Database.3pm.gz
-rw-r--r-- 1 root root 1537 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Store::MySQL.3pm.gz
-rw-r--r-- 1 root root 1428 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Store::Pg.3pm.gz
-rw-r--r-- 1 root root 1458 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::Store::SQLite.3pm.gz
-rw-r--r-- 1 root root 1360 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::TestConfig::Utilities.3pm.gz
-rw-r--r-- 1 root root 2218 oct. 19 21:27
/usr/share/man/man3/Wiki::Toolkit::TestLib.3pm.gz
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit
-rw-r--r-- 1 root root 31970 déc. 31 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit.pm
-rw-r--r-- 1 root root 5446 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Extending.pod
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Feed
-rw-r--r-- 1 root root 13449 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Feed/Atom.pm
-rw-r--r-- 1 root root 6834 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Feed/Listing.pm
-rw-r--r-- 1 root root 16587 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Feed/RSS.pm
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Formatter
-rw-r--r-- 1 root root 4377 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Formatter/Default.pm
-rw-r--r-- 1 root root 4162 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Formatter/Multiple.pm
-rw-r--r-- 1 root root 2844 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Formatter/WikiLinkFormatterParent.pm
-rw-r--r-- 1 root root 5534 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Plugin.pm
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search
-rw-r--r-- 1 root root 6536 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search/Base.pm
-rw-r--r-- 1 root root 3301 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search/DBIxFTS.pm
-rw-r--r-- 1 root root 9072 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search/Lucy.pm
-rw-r--r-- 1 root root 5963 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search/Plucene.pm
-rw-r--r-- 1 root root 4042 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Search/SII.pm
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup
-rw-r--r-- 1 root root 3113 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/DBIxFTSMySQL.pm
-rw-r--r-- 1 root root 11039 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/Database.pm
-rw-r--r-- 1 root root 13669 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/MySQL.pm
-rw-r--r-- 1 root root 15757 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/Pg.pm
-rw-r--r-- 1 root root 2212 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/SII.pm
-rw-r--r-- 1 root root 11981 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Setup/SQLite.pm
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Store
-rw-r--r-- 1 root root 73349 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Store/Database.pm
-rw-r--r-- 1 root root 2647 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Store/MySQL.pm
-rw-r--r-- 1 root root 2281 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Store/Pg.pm
-rw-r--r-- 1 root root 2722 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/Store/SQLite.pm
drwxr-xr-x 2 root root 0 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/TestConfig
-rw-r--r-- 1 root root 903 oct. 19 21:27
/usr/share/perl5/vendor_perl/Wiki/Toolkit/TestConfig.pm
-rw-r--r-- 1 root root 6098 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/TestConfig/Utilities.pm
-rw-r--r-- 1 root root 12179 déc. 16 2016
/usr/share/perl5/vendor_perl/Wiki/Toolkit/TestLib.pm
File permissions and layout are Ok.
$ rpm -q --requires -p perl-Wiki-Toolkit-0.85-1.fc30.noarch.rpm | sort -f |
uniq -c
1 /usr/bin/perl
1 perl(:MODULE_COMPAT_5.28.0)
1 perl(:VERSION) >= 5.6.0
1 perl(base)
1 perl(Carp)
1 perl(CGI)
1 perl(DBI)
1 perl(Digest::MD5)
1 perl(File::Spec::Functions)
1 perl(Getopt::Long)
1 perl(HTML::PullParser)
1 perl(POSIX)
1 perl(strict)
1 perl(Text::WikiFormat)
1 perl(Time::Piece)
1 perl(Time::Seconds)
1 perl(URI::Escape)
1 perl(vars)
1 perl(Wiki::Toolkit)
1 perl(Wiki::Toolkit::Feed::Listing)
1 perl(Wiki::Toolkit::Formatter::WikiLinkFormatterParent)
1 perl(Wiki::Toolkit::Search::Base)
1 perl(Wiki::Toolkit::Search::SII)
1 perl(Wiki::Toolkit::Setup::Database)
1 perl(Wiki::Toolkit::Store::Database)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
You have BuildRequires: perl(CGI) listed two times.
$
rpm -q --provides -p perl-Wiki-Toolkit-0.85-1.fc30.noarch.rpm
perl(Wiki::Toolkit) = 0.85
perl(Wiki::Toolkit::Feed::Atom) = 0.03
perl(Wiki::Toolkit::Feed::Listing)
perl(Wiki::Toolkit::Feed::RSS) = 0.11
perl(Wiki::Toolkit::Formatter::Default) = 0.02
perl(Wiki::Toolkit::Formatter::Multiple) = 0.02
perl(Wiki::Toolkit::Formatter::WikiLinkFormatterParent) = 0.01
perl(Wiki::Toolkit::Plugin) = 0.04
perl(Wiki::Toolkit::Search::Base) = 0.01
perl(Wiki::Toolkit::Search::DBIxFTS) = 0.05
perl(Wiki::Toolkit::Search::Lucy) = 0.03
perl(Wiki::Toolkit::Search::Plucene) = 0.02
perl(Wiki::Toolkit::Search::SII) = 0.09
perl(Wiki::Toolkit::Setup::DBIxFTSMySQL) = 0.04
perl(Wiki::Toolkit::Setup::Database) = 0.09
perl(Wiki::Toolkit::Setup::MySQL) = 0.10
perl(Wiki::Toolkit::Setup::Pg) = 0.10
perl(Wiki::Toolkit::Setup::SII) = 0.03
perl(Wiki::Toolkit::Setup::SQLite) = 0.10
perl(Wiki::Toolkit::Store::Database) = 0.31
perl(Wiki::Toolkit::Store::MySQL) = 0.05
perl(Wiki::Toolkit::Store::Pg) = 0.07
perl(Wiki::Toolkit::Store::SQLite) = 0.06
perl(Wiki::Toolkit::TestConfig::Utilities) = 0.06
perl(Wiki::Toolkit::TestLib) = 0.05
perl-Wiki-Toolkit = 0.85-1.fc30
Binary provides are Ok.
Package builds in Koji
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=30334066).
Ok
The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component