https://bugzilla.redhat.com/show_bug.cgi?id=1239273
Julien Enselme <jujens(a)jujens.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jchaloup(a)redhat.com
--- Comment #2 from Julien Enselme <jujens(a)jujens.eu> ---
- Files not included twice any more
- Correct dist tag
- License. Issue opened here:
https://github.com/BurntSushi/toml-test/issues/32
- dir
- %build honors applicable compiler flags or justifies otherwise. If I
understand this correctly it is note required for the debug package which I
don't build since find-debuginfo.sh cannot extract debug info from package
(comment added in the spec).
- debuginfo: cannot build. I have the rpm version reference in
https://bugzilla.redhat.com/show_bug.cgi?id=1184221, yet I still cannot build
the package, see above. I am not sure if the issue are related or not.
- Use ExclusiveArch: %{go_arches}. I guess I get too much inspiration from
http://pkgs.fedoraproject.org/cgit/golang-github-BurntSushi-toml.git/tree...
and not from the guidelines. There is a pending package in review
(
https://bugzilla.redhat.com/show_bug.cgi?id=1241156) to help building golang
packages for architectures only supported by gcc-go. I will follow the
discussion on devel
(
https://lists.fedoraproject.org/pipermail/devel/2015-July/212117.html) and see
what happens. I don't think I have enough experience with go to review the
package. If a consensus emerge on devel, I will update this package
accordingly.
- devel package requires standard package
- %defined instead of %global: that a mistake, I correct the macro to %gobal.
About the possible conflict with golang-github-BurntSushi-toml:
This looks like a collision with the BurntSushi/toml (same upstream
maintainer), which is already packaged for Fedora. It isn't clear to
me which of the two packages should be the canonical one for this
directory, but this needs resolving, and one package then should
probably require the other. Or perhaps it's ok for both packages to
own the directory as long as there are no file collisions in the
directory. This needs a careful audit.
In my opinion, the fact that /usr/share/gocode/src/github.com/BurntSushi
shouldn't cause trouble the the files for golang-github-BurntSushi-toml will be
located in /usr/share/gocode/src/github.com/BurntSushi/toml and the one for
golang-github-BurntSushi-toml-test in
/usr/share/gocode/src/github.com/BurntSushi/toml-test. But requiring
golang-github-BurntSushi-toml in golang-github-BurntSushi-toml-test can be a
solution even if golang-github-BurntSushi-toml is not required in any way.
I took the liberty to add jchaloup in CC's as the main contact for
golang-github-BurntSushi-toml reference here
https://admin.fedoraproject.org/pkgdb/package/golang-github-BurntSushi-toml/
and I guess that his opinion can be useful on this matter.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component