Comment # 2 from
(In reply to comment #1)
> Hi,
> 
> a few comment on the spec  :
> - you should have a -devel subpackage for developpement related files ( .h,
> .pc, etc )
> https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
> 
> 
> - I am not sure, but I think there was some discussion regarding the place
> of vala files. However, that's not in the policy yet, so I would just
> suggest to keep a eye on it
> 
> - the package do not compile on rawwhide ( it does on f17 however ). Not
> sure why, but you can check with mock.
> 
> - the license tag is invalid 
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Valid_License_Short_Names
> 
> - there is no ldconfig call in %post, and that's kinda required
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
I added sub-package devel but not sure if that is correct:
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-2.fc16.src.rpm

By the way fixed the license tag and added the ldconfig in post and postun


You are receiving this mail because: