Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225254
Jon Ciesla <limburgher(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |limburgher(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |limburgher(a)gmail.com
Flag| |fedora-review?
--- Comment #13 from Jon Ciesla <limburgher(a)gmail.com> 2012-04-03 13:13:21 EDT ---
Fresh review:
Good:
- rpmlint checks return:
apr-util-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-devel.x86_64: W: no-manual-page-for-binary apu-1-config
Each executable in standard binary directories should have a man page.
apr-util-freetds.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-ldap.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-mysql.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-nss.x86_64: W: spelling-error Summary(en_US) crytpo -> crypt
The value of this tag appears to be misspelled. Please double-check.
apr-util-nss.x86_64: W: spelling-error %description -l en_US crypto -> crypt,
crypts, crypt o
The value of this tag appears to be misspelled. Please double-check.
apr-util-nss.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-odbc.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-openssl.x86_64: W: spelling-error Summary(en_US) crytpo -> crypt
The value of this tag appears to be misspelled. Please double-check.
apr-util-openssl.x86_64: W: spelling-error %description -l en_US crypto ->
crypt, crypts, crypt o
The value of this tag appears to be misspelled. Please double-check.
apr-util-openssl.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-pgsql.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
apr-util-sqlite.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
Mostly ignorable.
- package meets naming guidelines
- package meets packaging guidelines
- license ( ASL 2.0 ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
Patch from comment * should be applied.
- post/postun ldconfig ok
- devel requires base package n-v-r
So it's pretty much just the static lib issue. Let me know if you want me to
commit anything.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.