https://bugzilla.redhat.com/show_bug.cgi?id=2017610
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(vanessaigwe1@gmai
| |l.com)
--- Comment #6 from Ben Beasley <code(a)musicinmybrain.net> ---
Sorry for keeping you waiting on this review. Before I finish the full review,
I have a question: why did you choose to package from commit 8aaf3e8 rather
than from the tag for version 0.4.2? Is there a particular fix you need from
the commits after the 0.4.2 tag?
It’s ok to do this (preferably given a concrete reason, which it’s nice to
mention in a spec file comment), but you’ll need to ensure the snapshot
information field is in the Release
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_sn...).
The easiest way to add the snapshot information is to use the “forge” macros
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_com...).
----
Other things at a glance:
- I think CODE_OF_CONDUCT.md, CONTRIBUTING.md, and CREDITS.md should be
installed with %doc, too.
- While patching pyproject.toml to allow Jinja2 version 3.x is correct, you
should ideally file an upstream issue asking them to add official support.
----
I’ll spend a little more time on it before posting the final review, but I
don’t think I’ll find anything else—I can tell you’ve packaged carefully.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2017610