Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=664912
--- Comment #14 from Ralf Corsepius <rc040203(a)freenet.de> 2012-01-16 07:58:07 EST
---
(In reply to comment #13)
This is rebase to 0.15. Performing complete review.
Source tar ball is original. Ok.
Summary verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
License verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
URL and Source0 verified. Ok.
FIX: Augment description text to cover this package. Current sentence talks
about different Perl package only.
This is upstream's description, as cpanspec
had extracted it.
I can add the next line from upstream's desciption, if you like this better.
FIX: Build-require perl(Carp)
(lib/HTML/TreeBuilder/LibXML/Node.pm:4).
TODO: Build-require perl(base) (lib/HTML/TreeBuilder/LibXML.pm:6)
perl(base) is
never going to move outside of the perl package.
And even if, this will be causing an FTBS, which can be fixed then.
Enforcing BR: perl(base) is bureacratic nit-pickery.
TODO: Remove useless %defattr from %files section.
Will not do
so - %defattr is still allowed, not using it is not mandated.
You are enforcing a non existing rule.
Resolution: Package NOT approved.
Petr, some open and direct words: In case you're not aware about it, the style
of your reviews is hardly bearable and childishly pedantic.
It is driving people away from Fedora.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.