https://bugzilla.redhat.com/show_bug.cgi?id=1306258
--- Comment #1 from T. Orsava <torsava(a)redhat.com> ---
Hi, here's the review (my first!):
- change URL to point to the upstream home page instead of pypi
- suggestion: include PKG-INFO as a %doc
- suggestion: set permissions on LICENSE file to 644 instead of the current 664
- fix rpmlint warning: python2-Lektor.noarch: W: hidden-file-or-dir
/usr/lib/python2.7/site-packages/lektor/quickstart-templates/plugin/.gitignore.in
(I suggest deleting the file before %install)
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/lektor
- change line "{python2_sitelib}/lektor/*" to
"{python2_sitelib}/lektor"
[ ]: Changelog in prescribed format.
- format is "Firstname Lastname", you have them reversed
[ ]: Requires correct, justified where necessary.
- add requires on Jinja2>=2.4 as per requires.txt
[ ]: Latest version is packaged.
- version 1.1 is in spec file, 1.2.1 is available upstream
[x]: Reviewer should test that the package builds in mock.
- builds in rawhide, but fails: pkg_resources.DistributionNotFound: The
'argh>=0.24.1' distribution was not found and is required by watchdog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component