Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788592
Michal Fojtik <mfojtik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mfojtik(a)redhat.com
Flag| |fedora-review+
--- Comment #1 from Michal Fojtik <mfojtik(a)redhat.com> 2012-02-10 04:47:51 EST ---
Review:
* Packages that contain Ruby Gems must be called rubygem-%{gemname} where
gemname is the name from the Gem's specification.
OK
The Source of the package must be the full URL to the released Gem archive; the
version of the package must be the Gem's version
OK
The package must have a Requires and a BuildRequires on rubygems
OK
The package must provide rubygem(%{gemname}) where gemname is the name from the
Gem's specification. For every dependency on a Gem named gemdep, the package
must contain a Requires on rubygem(%{gemdep}) with the same version constraints
as the Gem
OK
The %prep and %build sections of the specfile should be empty.
OK (Patch is being applied, so %prep is not empty)
The Gem must be installed into %{gemdir}
OK
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
OK
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
It's possible to update guidelines to for excluding cache ^^ ? (not a review
blocker)
=====================================
This package looks safe, license is sane and patching was properly described in
a comment. REVIEW+
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.