https://bugzilla.redhat.com/show_bug.cgi?id=1668010
--- Comment #6 from Felix Schwarz <fschwarz(a)fedoraproject.org> ---
1. "LICENSE" file not installed (%license)
2. /usr/bin/hipconfig contains some unpatched paths:
$CUDA_PATH=$ENV{'CUDA_PATH'} // '/usr/local/cuda';
$HCC_HOME=$ENV{'HCC_HOME'} // '/opt/rocm/hcc';
$HSA_PATH=$ENV{'HSA_PATH'} // '/opt/rocm/hsa';
3. /usr/bin/hipcc - unpatched paths
- HIP_PATH defaults to "/usr" but $HIP_INCLUDE_PATH is defined as
"$HIP_PATH/include" (-> $HIP_PATH/include/hip?).
- from a quick glance it seems as if »$HIP_PLATFORM = "clang"« won't work
as
no default path is set? (just from reading the code)
- missing requires: hipcc requires coreutils, grep, gcc, gcc-c++ (the latter
two are only required for a CentOS 7-specific workaround)
4. /usr/lib64/libhip_hcc.so.1.5
- executable-stack
- E: binary-or-shlib-defines-rpath /usr/lib64/libhip_hcc.so.1.5 ['/usr/lib64']
5. hipexamine.sh, hipconvertinplace.sh non-functional
- "hipify-clang" is no built (not built by default), both scripts rely on that
- probably best to remove these scripts entirely (I guess there is a reason
why upstream does not build them by default)
6. In general I find that the hip package "clutters" /usr/bin/ a bit too much.
Things like 'findcode.sh' could go into "libexec" (but that might be
just
personal preference). Also I'm a bit worried about the "ca" binary - that
name
is extremly generic ("certificate authority"?)
7. from a quick glance it seems as if "clara.hpp" is a header-only copylib.
"bundles(clara)"?
8. license tag only lists MIT but licensecheck disagrees:
*No copyright* GNU Lesser General Public License (v2.1 or later)
----------------------------------------------------------------
HIP-roc-2.0.0/util/gedit/hip.lang
BSD 3-clause "New" or "Revised" License
---------------------------------------
HIP-roc-2.0.0/samples/1_Utils/hipBusBandwidth/LICENSE.txt
HIP-roc-2.0.0/samples/1_Utils/hipCommander/LICENSE.txt
BSL (v1.0)
----------
HIP-roc-2.0.0/lpl_ca/pstreams/pstream.h
9. hipdemangleatp.sh: missing requires:
- sed, binutils, coreutils
I have to say that I find "hip" even scarier to review with its static
libraries and all the duplicated shell/perl code...
Also I did not have time yet to actually try the hip so there may be more
issues. Anyway thanks for your work so far :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component