https://bugzilla.redhat.com/show_bug.cgi?id=2149953
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
(In reply to blinxen from comment #4)
Taking this review
Some comments / issues with the package:
- The upstream project does not include a license file in `Cargo.toml`. I
can see that you add it manually but it would be nice if you could push the
change to upstream. Maybe by specifying `license-file` [1]?.
No. The `license-file` field in Cargo.toml is supposed to only be used if the
license is non-standard (i.e. custom license with no corresponding SPDX
identifier).
- The license path for the `devel` package is wrong. It should be
`%license
%{crate_instdir}/LICENSE`.
That *would* be true, but the upstream Cargo.toml specifies files to include,
and `LICENSE` is not among the listed files. So it cannot be referenced this
way unless the `include` setting in Cargo.toml is also fixed to include the
"LICENSE" file. Otherwise it will not get copied to %{crate_instdir}.
- `rust2rpm` always adds the `%doc` directive to `devel` packages. I
am not
sure if this is actually required as I couldn't find anything about it in
the guidelines but I think adding it shouldn't hurt. Something like `%doc
%{crate_instdir}/README.md`
Yes, this line seems to be missing from the -devel subpackage's files:
%doc %{crate_instdir}/README.md
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2149953