https://bugzilla.redhat.com/show_bug.cgi?id=2031583
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(mike@flyn.org) CC| |zebob.m@gmail.com
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Version 2.1.3 doesn't exist anymore, just go with 2.1.2
- the patch is not needed, just fix the import path of the fork:
sed -i "s|github.com/nicksnyder/go-i18n|github.com/gohugoio/go-i18n|" $(find . -iname "*.go" -type f)
- a test fails with a recent version of Go, it has been fixed upstream, let's backport the patch :
# https://github.com/gohugoio/hugo/issues/11336 Patch: https://github.com/nicksnyder/go-i18n/commit/dadad2bdb2a713748df0717eddd5449...
I sent a bug report upstream for them to backport the upstream changes.
- update the spec with latest go2rpm + fix some stuff:
# Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil}
# https://github.com/gohugoio/go-i18n %global goipath github.com/gohugoio/go-i18n Version: 2.1.2
%gometa -f
%global common_description %{expand: A Go package and a command that helps you translate Go programs into multiple languages.}
%global golicenses LICENSE
Name: %{goname} Release: %autorelease Summary: Go tools for translating Go programs into multiple languages
License: MIT URL: %{gourl} Source0: %{gosource} # https://github.com/gohugoio/hugo/issues/11336 Patch: https://github.com/nicksnyder/go-i18n/commit/dadad2bdb2a713748df0717eddd5449...
%description %{common_description}
%gopkg
%prep %goprep %autopatch -p1 sed -i "s|github.com/nicksnyder/go-i18n|github.com/gohugoio/go-i18n|" $(find . -iname "*.go" -type f)
%generate_buildrequires %go_generate_buildrequires
%install %gopkginstall
%check %gocheck
%gopkgfiles
%changelog %autochangelog
The following review was conducted on my update:
- License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines
Please check what I said above and I'll approve.