Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=733603
Peter Robinson <pbrobinson(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #19 from Peter Robinson <pbrobinson(a)gmail.com> 2011-09-12 17:42:16 EDT
---
Of the outstanding. rpmlint looks fine, son is a proper locale, even if rpmlint
doesn't know of it :)
+ Summary and Description updates
+ rplint
$ rpmlint sugar-ruler-12-1.fc15.src.rpm sugar-ruler-12-1.fc15.noarch.rpm
sugar-ruler.spec
sugar-ruler.src: W: non-standard-group Sugar/Activities
sugar-ruler.src:54: W: macro-in-%changelog %{__python}
sugar-ruler.src:62: W: macro-in-%changelog %clean
sugar-ruler.src:64: W: macro-in-%changelog %{buildroot}
sugar-ruler.noarch: W: non-standard-group Sugar/Activities
sugar-ruler.noarch: E: invalid-lc-messages-dir
/usr/share/locale/son/LC_MESSAGES/com.laptop.Ruler.mo
sugar-ruler.spec:6: W: non-standard-group Sugar/Activities
sugar-ruler.spec:54: W: macro-in-%changelog %{__python}
sugar-ruler.spec:62: W: macro-in-%changelog %clean
sugar-ruler.spec:64: W: macro-in-%changelog %{buildroot}
2 packages and 1 specfiles checked; 1 errors, 9 warnings.
$ rpm -qf /usr/share/locale/son/LC_MESSAGES/
filesystem-2.4.41-1.fc15.x86_64
$
- the pthon install macro still needs to be fixed:
%build
%{__python} ./setup.py build
%install
python ./setup.py install --prefix=%{buildroot}/%{_prefix}
All the rest looks fine. I'm approving this, please fix the install macro
before you commit
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.