https://bugzilla.redhat.com/show_bug.cgi?id=1745478
Dan Horák <dan(a)danny.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |dan(a)danny.cz
Assignee|nobody(a)fedoraproject.org |dan(a)danny.cz
--- Comment #1 from Dan Horák <dan(a)danny.cz> ---
first round of comments
- drop Group: - it's ignored
- drop Packager: - filled by the build system
- drop %clean - rpmbuild does it automagically
- drop all %attr() - rpmbuild set them automagically
- License tag must use Fedora identifiers - "LGPLv2 or BSD"
- %{_libdir}/libbpf.so belongs to -devel subpackage
- -devel subpackage should own %{_includedir}/bpf directory, you might use
wildcard to include the individual headers, or even list only the "bpf"
directory
- ideally the static library shouldn't be packaged, if it's a must, then it
belong to a separate -static subpackage
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-stat...)
- omit %dist in changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component