https://bugzilla.redhat.com/show_bug.cgi?id=1088950
--- Comment #3 from Paul Howarth <paul(a)city-fan.org> ---
(In reply to David Dick from comment #1)
Licensing is correct
MUST FIX:
BR: perl(Test::Script) # line 52 of t/00-compile.t
BR: perl(File::Find) # line 21 of t/00-compile.t
Added perl(File::Find) to the test suite buildreqs and perl(Test::Script) to
the optional tests buildreqs, though it never gets run as this dist doesn't
include any scripts.
OPTIONAL
I can't see any reference that requires
BR: perl(Test::Pod::Content)
this can probably be removed.
Without it, you get this:
$ make test RELEASE_TESTING=1
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM"
"-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib',
'blib/arch')"
t/*.t
t/00-compile.t .................. skipped: no tests to run
t/01use.t ....................... ok
t/10simple.t .................... ok
t/11default.t ................... ok
t/12config_any_args.t ........... ok
t/author-critic.t ............... skipped: these tests are for testing by the
author
t/multiple.t .................... ok
t/release-check-changes.t ....... ok
# Test::Pod::Content required to test POD version consistency
# Distribution version: 0.11
t/release-consistent-version.t .. ok
# Unable to parse MANIFEST.SKIP file:
# No such file or directory
# Using default skip data from ExtUtils::Manifest 1.63
t/release-dist-manifest.t ....... ok
t/release-distmeta.t ............ ok
t/release-eol.t ................. ok
t/release-has-version.t ......... ok
t/release-kwalitee.t ............ ok
t/release-minimum-version.t ..... ok
t/release-no-tabs.t ............. ok
t/release-pod-coverage.t ........ ok
t/release-pod-syntax.t .......... ok
t/release-portability.t ......... ok
t/release-unused-vars.t ......... ok
All tests successful.
I guess Test::Pod::Content should be a dependency of the
Test::ConsistentVersion package really (Bug #1091285).
rpmlint notes the incorrect-fsf-address issue with this package. If
you
want, you can inform upstream.
Probably no need; upstream uses Dist::Zilla, which should fix it automatically
next time a release is done (this release is from 2011).
As the other EL5 stuff has been removed, you can remove
rm -rf %{buildroot}
as well
Done.
Notes
perl(YAML) correctly not required b/c perl(YAML::Syck) is preferred by
module author
Indeed.
All addressed in -2:
Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-MouseX-SimpleConfig/br...
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-MouseX-SimpleConfig/perl-MouseX...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component