https://bugzilla.redhat.com/show_bug.cgi?id=1853888
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #4 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
- Source must point to the upstream archive URL
Source: %{name}-%{version}.tar.gz
-
https://codecolla.com:10734/ doesn't resolve for me. Where to get the source
code *officially*?
- Do not gzip the man pages yourself, it is handled by RPM
- Please remove the gz extension for man page in %files and use a glob *
instead, as compression may change in the future.
%{_mandir}/man3/LTK.3.gz
%{_mandir}/man3/LTKAdd.3.gz
%{_mandir}/man3/LTKArray.3.gz
%{_mandir}/man3/LTKBacktrace.3.gz
%{_mandir}/man3/LTKCtd.3.gz
%{_mandir}/man3/LTKCtl.3.gz
%{_mandir}/man3/LTKExec.3.gz
%{_mandir}/man3/LTKHash.3.gz
%{_mandir}/man3/LTKLog.3.gz
%{_mandir}/man3/LTKNum.3.gz
%{_mandir}/man3/LTKRand.3.gz
%{_mandir}/man3/LTKRun.3.gz
%{_mandir}/man3/LTKTrg.3.gz
→
%{_mandir}/man3/LTK*.3.*
- includes go to the devel package:
%files devel
%{_includedir}/%{name}.%{version}
%{_includedir}/%{name}
- The unversioned library goes to devel subpackage too:
%{_libdir}/lib%{name}.so
- Why do you repeat: mkdir -p %{buildroot}%{_mandir}/man3 several times? It
only needs to be created once. Try simplify the copy code too
mkdir -p %{buildroot}%{_mandir}/man3
cp -a man/LTK*.3 %{buildroot}%{_mandir}/man3/
- This is not good:
%build
make NAME=%{name} VERSION=%{version}
You need to make sure that Fedora build flags are respected while compiling:
We have %set_build_flags to define them but you also need to make sure that the
Makefile will respect these flags (CFLAGS, LDFLAGS). I checked the Makefile it
seems good so you just need to do:
%build
%set_build_flags
%make_build NAME=%{name} VERSION=%{version}
If possible use: %make_build to do // compilation:
%make_build NAME=%{name} VERSION=%{version}
- install -m 755 -D bin/lib%{name}.so
%{buildroot}%{_libdir}/lib%{name}.so.%{version}
This is not sufficient to set a SONAME, it's just create a link. Setting a
soname is mandatory in Fedora, generally ask upstream to do it, or if they
refuse, add it to your Fedora package. Should be something like:
gcc -shared -fPIC -Wl,-soname,libfoo.so.1 -o libfoo.so.1.0.0 foo.c
when building your package. Patch the Makefile to add your SONAME if upstream
is not responsive.
- Use install -p to keep timestamps.
- Feel free to link to COPR build for your SPEC and SRPM (just don't delete
them)
- Feel free to converse in French if needed.
- Separate your changelog entries with a newline
- Add version-release number to your changelog entries
- Main package should be named libLTK. The same name to be used for the SPEC
filename, the bug report name and the Name: of the SPEC.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component