https://bugzilla.redhat.com/show_bug.cgi?id=1975046
Arthur Bols <arthur(a)bols.dev> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arthur(a)bols.dev
--- Comment #2 from Arthur Bols <arthur(a)bols.dev> ---
Hi,
Please note that this a preliminary review.
I checked the license situation (and reread the licensing guidelines) and I
think it should be fine.
rpmlint reports errors for check_blas.py and check_multi_gpu.py even though you
tried to fix it :/
python3-aesara.noarch: E: non-executable-script
/usr/lib/python3.10/site-packages/aesara/misc/check_blas.py 644 /usr/bin/env
python
python3-aesara.noarch: E: non-executable-script
/usr/lib/python3.10/site-packages/aesara/misc/check_multi_gpu.py 644
/usr/bin/env python
Would it be better to use the sources from github? This way you could include
the tests and create a *-doc package.
Some small suggestions:
- Change pytest to the %pytest macro.
- Change python3-setuptools to python3dist(setuptools)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component