https://bugzilla.redhat.com/show_bug.cgi?id=1919639
--- Comment #4 from Hans de Goede <hdegoede(a)redhat.com> ---
Some more remarks:
"License: GPLv2"
The orginal dosbox is GPLv2 or later, which we write as GPLv2+, is this not the
case for dosbox-x?
Please drop all the Requires: on libraries rpm will auto generate these based
on the used sonames. Note you will want to keep the fluid-soundfont-gm
Requires.
"""
desktop-file-install \
--dir=%{buildroot}%{_datadir}/applications \
--set-icon=com.dosbox_x.DOSBox-X \
contrib/linux/com.dosbox_x.DOSBox-X.desktop
install -p -m 0644 contrib/icons/dosbox-x.svg
%{buildroot}%{_datadir}/icons/hicolor/scalable/apps/com.dosbox_x.DOSBox-X.svg
%exclude %{_datadir}/icons/hicolor/scalable/apps/dosbox-x.svg
"""
Maybe just have the .desktop file used the already installed dosbox-x.svg ?
"install -p -m 0644 -Dt %{buildroot}%{_datadir}/%{name}/glshaders
contrib/glshaders/*.glsl"
Why ? Please add a comment explaining why this is done
Please verify the installed appdata file:
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component