Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension
https://bugzilla.redhat.com/show_bug.cgi?id=755510
Summary: Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nicolas.vieville@univ-valenciennes.fr QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://dl.dropbox.com/u/25699833/Fedora/gnome-shell-extension-system-monitor... SRPM URL: http://dl.dropbox.com/u/25699833/Fedora/gnome-shell-extension-system-monitor... SRPM URL: http://dl.dropbox.com/u/25699833/Fedora/gnome-shell-extension-system-monitor... Project URL: https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet
Description: Display system informations in gnome shell status bar, such as memory usage, cpu usage, network rates…
$ rpmlint gnome-shell-extension-system-monitor-applet.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint gnome-shell-extension-system-monitor-applet-1.99-1.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint gnome-shell-extension-system-monitor-applet-1.99-1.fc16.noarch.rpm gnome-shell-extension-system-monitor-applet.noarch: W: devel-file-in-non-devel-package /usr/bin/system-monitor-applet-config gnome-shell-extension-system-monitor-applet.noarch: W: no-manual-page-for-binary system-monitor-applet-config 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
As the SPEC file can build this gnome-shell-extension for F-15 and F-16, here is the rpmlint outputs on F-15 files. I was unable to deal with rpmlint errors with F-15 srpm file on a F-16 host (confusion about "dist" and "fedora" macros I suppose). But to be complete, mock builds this package for F-15 and F-16 without any problems. I haven't tried with rawhide. Should I? This is my first review for Fedora and my skill in such things is not complete.
$ rpmlint gnome-shell-extension-system-monitor-applet-1.99-1.fc15.src.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Traceback (most recent call last): File "/usr/bin/rpmlint", line 379, in <module> main() File "/usr/bin/rpmlint", line 169, in main runChecks(pkg) File "/usr/bin/rpmlint", line 229, in runChecks check.check(pkg) File "/usr/share/rpmlint/SpecCheck.py", line 143, in check self.check_spec(pkg, self._spec_file) File "/usr/share/rpmlint/SpecCheck.py", line 564, in check_spec pkgfile = pkg.files()[url.split("/")[-1]] KeyError: 'paradoxxxzero-gnome-shell-system-monitor-applet-1.99-78-g14ef176.tar.gz'
$ rpmlint gnome-shell-extension-system-monitor-applet-1.99-1.fc15.noarch.rpm gnome-shell-extension-system-monitor-applet.noarch: W: devel-file-in-non-devel-package /usr/bin/system-monitor-applet-config gnome-shell-extension-system-monitor-applet.noarch: W: no-manual-page-for-binary system-monitor-applet-config 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
This review request comes after this bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=710386
I'm a newcomer in such things for Fedora and not very familiar with packaging, but I'm volunteer for this package. I'll try to understand and to respect all the documentation and guidelines available on the contributor's part of the Fedora Web site, but any comments on the question are welcome. Last but not the least, as a newcomer, I'm also seeking a sponsor.
Thanks in advance for your comments.
Cordially,