https://bugzilla.redhat.com/show_bug.cgi?id=1728373
--- Comment #4 from Tomas Korbar <tkorbar(a)redhat.com> ---
Great! Now the review.
---------
16 BuildRequires: python3-devel
17 BuildRequires: python3dist(numpy) >= 1.7.1
18 BuildRequires: python3dist(setuptools)
19 BuildRequires: python3dist(sphinx)
20 BuildRequires: python3dist(numpydoc)
21 BuildRequires: python3-sphinx_rtd_theme
^^^ You should remove these build requirements for the unversioned python
package. They are not needed.
Look at example on python packaging guidelines at [0].
---------
24 %global debug_package %{nil}
^^^ Please remove this too. It is obsolete for python package.
---------
29 %package -n python3-%{pypi_name}
30 Summary: %{summary}
31 %{?python_provide:%python_provide python3-%{pypi_name}}
32
33 Requires: python3dist(numpy) >= 1.7.1
34 Requires: python3dist(setuptools)
^^^ Please list all build and runtime requirements here.
---------
The upstream has working tests so run them in %check phase.
I tried them so i can give you an advice.
+%check
+touch tests/data/__init__.py
+%{__python3} -m unittest discover
I had to create __init__.py to prevent FileNotFoundError.
Maybe you will find some better way but if you will not then contact please
upstream and discuss a solution of this with them.
---------
64 %{python3_sitelib}/*-py?.?.egg-info
^^^ At last but not least please change this regex to something more accurate.
%{python3_sitelib}/Glymur-%{version}-py?.?.egg-info
Something like this ^. Just to be sure that nothing unexpected will happen.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component