https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
Thank you for the quick review, Zbigniew.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> %global _description %{expand:
Nice trick.
Stole if from another spec I saw ;)
Please add a backslash at the end of this line, because otherwise there's an
spurious empty line in each "Description" section.
Done.
> %description doc
> %{_description}
Suggestion: maybe just say "documentation for %name".
Done
rpmlint:
> python3-duecredit.noarch: E: summary-too-long C Automated collection and reporting
of citations for used software/methods/datasets
Yeah, please fix.
Done.
+ package name is OK
+ license is acceptable (BSD)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ fedora-review finds no issues
+ BR/Requires/Provides look OK
Package is APPROVED.
Thanks. Here is the updated spec/srpm:
https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec
https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6...
Requesting scm now.
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component