Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785946
--- Comment #5 from Matthias Runge mrunge@matthias-runge.de 2012-02-06 14:43:37 EST --- Phew, this may get a little tough
Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST %config files are marked noreplace or the reason is justified. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST No %config files under /usr. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent.
rpmlint python-django-horizon-doc-2012.1-0.1.e3.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint openstack-dashboard-2012.1-0.1.e3.fc17.noarch.rpm
openstack-dashboard.noarch: W: no-documentation openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime /usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-06T20:14:22 /etc/openstack-dashboard/local_settings 2012-02-06T20:14:35 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.noarch.rpm
python-django-horizon.noarch: W: no-documentation python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/instances/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/flavors/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/services/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/nova/instances_and_volumes/volumes/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/images/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/quotas/tests.py python-django-horizon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/horizon/dashboards/settings/templates/settings/tenant/openrc.sh.template 0644L /bin/bash 1 packages and 0 specfiles checked; 7 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/785946/horizon-2012.1~e3.tar.gz : MD5SUM this package : 189c537031386cc7f140784bc124a50a MD5SUM upstream package : 189c537031386cc7f140784bc124a50a
[x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: SHOULD Dist tag is present. Note: Multiple Release tags found [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0:
http://launchpad.net/horizon/%%7Brelease_name%7D/%%7Brelease_name%7D-%%7Bmil... (horizon-%{version}~%{release_letter}%{milestone}.tar.gz) Source1: openstack-dashboard.conf (openstack-dashboard.conf) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Issues: [!]: MUST Rpmlint output is silent.
rpmlint python-django-horizon-doc-2012.1-0.1.e3.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint openstack-dashboard-2012.1-0.1.e3.fc17.noarch.rpm
openstack-dashboard.noarch: W: no-documentation openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime /usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-06T20:14:22 /etc/openstack-dashboard/local_settings 2012-02-06T20:14:35 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.noarch.rpm
python-django-horizon.noarch: W: no-documentation python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/instances/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/flavors/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/services/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/nova/instances_and_volumes/volumes/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/images/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/quotas/tests.py python-django-horizon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/horizon/dashboards/settings/templates/settings/tenant/openrc.sh.template 0644L /bin/bash 1 packages and 0 specfiles checked; 7 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Issues: - you should fix your buildreqires: BuildRequires: openstack-glance BuildRequires: python-cloudfiles >= 1.7.9.3 BuildRequires: python-dateutil BuildRequires: python-keystoneclient BuildRequires: python-novaclient >= 2012.1 BuildRequires: python-quantumclient
I cannot see, why those are required for build.
- You should clean up those zero-length files. - look at the files in horizon-2012.1/horizon/horizon/utils: they're licensed BSD, not ASL2. They're (basicly copied) from djangoproject.org (as the files state)
- please take a look onto openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime /usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-06T20:14:22 /etc/openstack-dashboard/local_settings 2012-02-06T20:14:35 this should be fixed.
not approving yet.