https://bugzilla.redhat.com/show_bug.cgi?id=1911565
dan.cermak(a)cgc-instruments.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |dan.cermak@cgc-instruments.
| |com
--- Comment #1 from dan.cermak(a)cgc-instruments.com ---
Overall this looks good to me, here are a few suggestions:
- please BuildRequire systemd to get the correct directory ownership of
/usr/lib/sysusers.d
- use the %{version} macro everywhere, so that you don't have to change the
hardcoded version in all places every time there is a new release, so e.g.
Source0:
https://github.com/derekp7/snebu/releases/download/v1.1.1/snebu-1.1.1.tar.gz
becomes:
Source0:
https://github.com/derekp7/%{name}/releases/download/v%{version}/%{name}-...
- use more macros & modern macros, e.g. instead of %setup -q use %autosetup,
you can also replace the make install with %make_install (you'll have to add
your prefix override to that though), replace all paths for which there are
macros with those (/etc -> %_sysconfdir, /usr/bin/ -> %_bindir)
- please add newlines between the changelog entries
- Consider marking the config file with noreplace or add a comment to the spec
why it is not marked as such. Also, since you're upstream, you might want to
consider shipping a default config in /usr/ and allow the admin/user to supply
their own overrides via /etc/snebu.conf leveraging libeconf
(
https://github.com/openSUSE/libeconf)
- you can replace this:
%license /usr/share/doc/snebu/COPYING.txt
with
%license COPYING.txt
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component