Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454120
Ville Skyttä <ville.skytta(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ville.skytta(a)iki.fi
AssignedTo|nobody(a)fedoraproject.org |ville.skytta(a)iki.fi
--- Comment #3 from Ville Skyttä <ville.skytta(a)iki.fi> 2008-08-25 04:04:52 EDT ---
License (GPLv2) does not look correct to me. The streamdev sources just refer
to COPYING without specifying a GPL version which makes them GPL+, and
libdvbmpeg is GPLv2+. I suppose "License: GPL+ and GPLv2+" would be correct.
Upstream probably meant the whole shebang to be GPLv2+, I'm sure they would
appreciate being notified.
The iconv stuff in %prep appears unnecessary, all those files are US-ASCII.
"Requires: vdr(abi) ..." should be moved to the -server and -client packages as
the "main" package does not produce a binary rpm and -server and -client
currently do not have a dependency on vdr.
vdr-streamdev-server.conf says "vdr-streamdev" and "streamdev", should
probably
be changed to "vdr-streamdev-server" and "streamdev-server".
Other than that, looks good, I'll complete the review when I have the chance to
try the binaries - I've just built the package and looked at the sources for
now.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.