https://bugzilla.redhat.com/show_bug.cgi?id=1654665
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Use DESTDIR
make pure_install DESTDIR=$RPM_BUILD_ROOT
URL and Source addresses are Ok.
Source archive (SHA-256:
47738d71b3efe399c07d15abf8a5d77702c63abfd014858d02535632b8ca8bd9) is original.
Ok.
Summary verified from lib/MooseX/SingleArg.pm. Ok.
Description verified from lib/MooseX/SingleArg.pm. Ok.
License verified from lib/MooseX/SingleArg.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
$ rpmlint perl-MooseX-SingleArg.spec
review-perl-MooseX-SingleArg/results/perl-MooseX-SingleArg-0.08-1.fc30.noarch.rpm
review-perl-MooseX-SingleArg/results/perl-MooseX-SingleArg-0.08-1.fc30.src.rpm
perl-MooseX-SingleArg.noarch: W: spelling-error Summary(en_US) instantiation ->
instantiate, substantiation, installation
perl-MooseX-SingleArg.noarch: W: spelling-error %description -l en_US arg ->
rag, gar, are
perl-MooseX-SingleArg.src: W: spelling-error Summary(en_US) instantiation ->
instantiate, substantiation, installation
perl-MooseX-SingleArg.src: W: spelling-error %description -l en_US arg -> rag,
gar, are
2 packages and 1 specfiles checked; 0 errors, 4 warnings
$ rpm -q -lv -p perl-MooseX-SingleArg-0.08-1.fc30.noarch.rpm
drwxr-xr-x 2 root root 0 nov. 30 21:24
/usr/share/doc/perl-MooseX-SingleArg
-rw-r--r-- 1 root root 613 mai 17 2018
/usr/share/doc/perl-MooseX-SingleArg/Changes
-rw-r--r-- 1 root root 1546 mai 17 2018
/usr/share/doc/perl-MooseX-SingleArg/META.json
-rw-r--r-- 1 root root 402 mai 17 2018
/usr/share/doc/perl-MooseX-SingleArg/README
-rw-r--r-- 1 root root 89 mai 17 2018
/usr/share/doc/perl-MooseX-SingleArg/cpanfile
drwxr-xr-x 2 root root 0 nov. 30 21:24
/usr/share/licenses/perl-MooseX-SingleArg
-rw-r--r-- 1 root root 18346 mai 17 2018
/usr/share/licenses/perl-MooseX-SingleArg/LICENSE
-rw-r--r-- 1 root root 2359 nov. 30 21:24
/usr/share/man/man3/MooseX::SingleArg.3pm.gz
drwxr-xr-x 2 root root 0 nov. 30 21:24
/usr/share/perl5/vendor_perl/MooseX
drwxr-xr-x 2 root root 0 nov. 30 21:24
/usr/share/perl5/vendor_perl/MooseX/SingleArg
-rw-r--r-- 1 root root 3701 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg.pm
drwxr-xr-x 2 root root 0 nov. 30 21:24
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta
-rw-r--r-- 1 root root 310 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta/Class.pm
-rw-r--r-- 1 root root 596 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta/Object.pm
-rw-r--r-- 1 root root 308 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta/Role.pm
-rw-r--r-- 1 root root 796 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta/ToClass.pm
-rw-r--r-- 1 root root 806 mai 17 2018
/usr/share/perl5/vendor_perl/MooseX/SingleArg/Meta/ToRole.pm
File permissions and layout are Ok.
$ rpm -q --requires -p perl-MooseX-SingleArg-0.08-1.fc30.noarch.rpm | sort -f
| uniq -c
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(Carp)
1 perl(Moose)
1 perl(Moose::Exporter)
1 perl(Moose::Role)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Add as a BR:
perl(Carp)
perl(Moose::Exporter)
perl(Moose::Role)
perl(strict)
perl(warnings)
$ rpm -q --provides -p perl-MooseX-SingleArg-0.08-1.fc30.noarch.rpm
perl(MooseX::SingleArg) = 0.08
perl(MooseX::SingleArg::Meta::Class) = 0.08
perl(MooseX::SingleArg::Meta::Object) = 0.08
perl(MooseX::SingleArg::Meta::Role) = 0.08
perl(MooseX::SingleArg::Meta::ToClass) = 0.08
perl(MooseX::SingleArg::Meta::ToRole) = 0.08
perl-MooseX-SingleArg = 0.08-1.fc30
Binary provides are Ok.
Package builds in Koji
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=31205424)
Ok
The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package approved. Please add the missing BR before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component