https://bugzilla.redhat.com/show_bug.cgi?id=1662526
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Wouldn't it make sense to move
%{_includedir}/nrnconf.h
into
%{_includedir}/%{tarname}
I don't know where packages that will BuildRequires: neuron-devel expect these
files to be, so I'll leave this up to you to decide.
Also, I wouldn't define a macro that is longer than what it expands into, i.e.
I'd just use "nrn" everywhere instead of %{tarname}.
None of the above are blockers and the package looks good otherwise, so
approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component