https://bugzilla.redhat.com/show_bug.cgi?id=1586291
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vondruch(a)redhat.com
--- Comment #1 from Vít Ondruch <vondruch(a)redhat.com> ---
I am not going to make a full review, but a few notes, since I already opened
the .spec file:
* The Source0 is fishy. Why don't you get the sources from GitHub?
* What is the "Release" tag about? Why 0.scratch.1?
* Group tag is not needed anymore.
* Is the "Requires: libslopy" really required? This dependency should be
autogenerated by RPM IMO.
* You should be following CMake guidelines [1].
* You should not need the %post/%postun sections anymore.
[1]
https://fedoraproject.org/wiki/Packaging:Cmake
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component