Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Test-Script - Cross-platform basic tests for scripts
https://bugzilla.redhat.com/show_bug.cgi?id=251128
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tcallawa@redhat.com 2007-09-18 13:32 EST ------- Good:
- rpmlint checks return: Nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL+ or Artistic) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (8ceb782be03c0e0ce6f3b7097a327361468628b0) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
As usual, good work with the package Ralf. APPROVED.