Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670541
Martin Gieseking <martin.gieseking(a)uos.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.gieseking(a)uos.de
--- Comment #1 from Martin Gieseking <martin.gieseking(a)uos.de> 2011-01-22 04:27:38
EST ---
Hi Jussi,
the package looks almost fine as far as I can see. Just a few things I noticed:
- %{?dist} is missing in the Release field
- the packaged source tarball differs from the upstream one:
$ md5sum libxc-1.0.tar.gz*
f9702268cf0015ada6a0ac34659971e6 libxc-1.0.tar.gz
4a8ef0c8fccc695e65466ec1a8878280 libxc-1.0.tar.gz.1
- maybe you want to use %{version} in Source0
- according to [1], %{_isa} must be added to Requires: gcc-gfortran
The directory %{_fmoddir} seems to be unowned. Unlike stated in [1],
gcc-gfortran doesn't seem to own it. But maybe I'm missing something.
[1]
http://fedoraproject.org/wiki/Packaging:Fortran
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.