https://bugzilla.redhat.com/show_bug.cgi?id=1656392
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> ---
Url and Source0 addresses are Ok.
The Source0 archive (SHA-256
e2aa12287b072d11eb7bc048dacc0918be34ddc3ace654697f0b5479f33b52d4) is Ok.
Summary verified from lib/JSON/Color.pm. Ok.
Description verified from lib/JSON/Color.pm. Ok.
License verified from LICENSE and lib/JSON/Color.pm. Ok.
No XS code, noarch BuildArch is Ok.
Build dependencies are Ok.
All tests pass. Ok.
$ rpmlint perl-JSON-Color.spec ../SRPMS/perl-JSON-Color-0.12-1.fc30.src.rpm
../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm
drwxr-xr-x 2 root root 0 Dec 5 15:42
/usr/share/doc/perl-JSON-Color
-rw-r--r-- 1 root root 1440 Aug 23 2016
/usr/share/doc/perl-JSON-Color/Changes
-rw-r--r-- 1 root root 1973 Aug 23 2016
/usr/share/doc/perl-JSON-Color/README
drwxr-xr-x 2 root root 0 Dec 5 15:42
/usr/share/licenses/perl-JSON-Color
-rw-r--r-- 1 root root 18367 Aug 23 2016
/usr/share/licenses/perl-JSON-Color/LICENSE
-rw-r--r-- 1 root root 2596 Dec 5 15:42
/usr/share/man/man3/JSON::Color.3pm.gz
drwxr-xr-x 2 root root 0 Dec 5 15:42
/usr/share/perl5/vendor_perl/JSON
-rw-r--r-- 1 root root 8076 Aug 23 2016
/usr/share/perl5/vendor_perl/JSON/Color.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm |
sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(:VERSION) >= 5.10.1
1 perl(Exporter)
1 perl(Scalar::Util::LooksLikeNumber)
1 perl(strict)
1 perl(Term::ANSIColor) >= 3.00
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: I think the `perl(Scalar::Util::LooksLikeNumber)' run-time dependency
could be weaker, like Recommends.
$ rpm -q --provides -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm |
sort -f | uniq -c
1 perl(JSON::Color) = 0.12
1 perl-JSON-Color = 0.12-1.fc30
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm
Binary dependencies resolvable. Ok.
The package builds in F30
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=31283761). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' item before building this package.
Resolution: APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component