https://bugzilla.redhat.com/show_bug.cgi?id=1594313
--- Comment #31 from jiri vanek <jvanek(a)redhat.com> ---
(In reply to Severin Gehwolf from comment #18)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed (FE-Legal clarification)
Issues:
=======
- Package java-11-openjdk provides "java" and "jre". Intentional?
Are we ready for people requiring "java" to get JDK-11?
For jre, yes,
for sdk, no.
This is aligned with java-openjdk, and up to now no issue caused.
The versionless sdk provides are the onse which have weight, and those are not
here - search for commented out provides which makes the crucial differences.
From other part, maybe you will recall the issue with to much commented out
provides when we were adding jdk7 to rhel6. That was quite disaster.
- Some licenses in sources are not listed in "License"
field.
I'm blocking FE-Legal for a review. Note that I've asked about
NTP license here:
Ok. this will be fixed by your patch as you write above
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/
thread/2QXHMTZ47DMMARJVI6PUMSYUPVFAGLCV/
- Please remove no longer needed defattr in %files. See below.
- Some descriptions/summaries exceed 79 characters. See:
This is so evil law... Its 21century. 99% monitors have width of 160 chars aat
*minimum*.
Will be fixed by best effort
https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-
long
Please fix descriptions/summaries. See rpmlint output.
- There are many typos in the spec file. Please run:
$ hunspell java-11-openjdk.spec
and fix them.
Funny. Manual correction by three people stay its place during java-openjdk
review.... Running it now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component