From bugzilla at redhat.com Fri Mar 12 04:04:03 2010 Content-Type: multipart/mixed; boundary="===============3150836221757709186==" MIME-Version: 1.0 From: Red Hat Bugzilla To: package-review at lists.fedoraproject.org Subject: [Bug 523877] Review Request: CBFlib - crystallography binary format library Date: Thu, 11 Mar 2010 23:02:59 -0500 Message-ID: <201003120402.o2C42xGB012417@bzweb01.app.bz.hst.phx2.redhat.com> In-Reply-To: bug-523877-197703@bugzilla.redhat.com --===============3150836221757709186== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=3D523877 --- Comment #20 from Chen Lei 2010-03-11 23:02:57 ES= T --- (In reply to comment #19) > (In reply to comment #18) > > I find that CBFlib tarball bundled some external python modules(dREL-pl= y, > > PyCifRW, ply), maybe we should remove and package those modules separat= ely. = > I'm not bothering with any of the python stuff with cbflib, and I don't p= lan to > unless there is a strong demand/need for it (which I don't forsee). = OK, but I still recommand you split -doc and -utils subpackage. CBFlib has a lot of documentation in it and both doc and html_graphics dirs need to be included in -doc subpackage. Also, The gpl.txt should not move out of doc d= ir, = grep gpl\.txt CBFlib.html CBFlib.html:YOU MAY REDISTRIBUTE THE CBFLIB PACKAGE UNDER THE TERMS OF T= HE GPL. grep \.jpg index.html 3D"[IUCr 3D"[CIF