[Bug 734531] New: Review Request: unison - File synchronisation tool
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: unison - File synchronisation tool
https://bugzilla.redhat.com/show_bug.cgi?id=734531
Summary: Review Request: unison - File synchronisation tool
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: unspecified
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: yellowcake-(a)gmx.net
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Spec URL: http://dl.dropbox.com/u/4023668/unison240.spec
SRPM URL: http://dl.dropbox.com/u/4023668/unison240-2.40.63-1.fc15.src.rpm
Description: Unison is a multi-master file-synchronization tool. It allows two
replicas of a collection of files and directories to be stored on
different hosts (or different locations on the same host), modified
separately, and then brought up to date by propagating the changes
in each replica to the other.
The unison package seems to be unmaintained (3 years since the last upgrade).
This is my first package. I used the old spec and upgraded it too the recent
stable version of unison. I may need a sponsor. unison240 fixes Bug 698833
(amongst others)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10 years, 9 months
[Bug 658754] Review Request: CUBRID - a very fast and reliable open source SQL database server.
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=658754
--- Comment #22 from Christopher Meng <cickumqt(a)gmail.com> ---
I provide some review of spec:
1. Please, do not use %define, Fedora now recommends %global instead of
%define.
2. Please, don't define the Release tag like "%{release}%{?dist}", just replace
it with 1%{?dist} is easy, right? You use about 30 chars space to define a
macro of "1", jesus..
3. And for the Group tag, you can safely drop them.
4. I noticed that you have some systemd macros, but the judge is for f15, and
please update.(I think you don't need to care about fedora 15 now. You can at
least push it to f19 now.)
Ref: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
5. I can see autogen, so please double check the Requires, I guess this might
not be built under mock
6. No need for rm -rf %{buildroot} in %install section
7. install should be with -p to preserve the timestamp.
8. Why %preun and %postun of -devel package have "-p /sbin/ldconfig"?
Duplicated?
9. I think you don't need to remove the cubrid user when removing. mariadb and
postgresql and many others don't do that.
10. As I've said before, cleanup the chkconfig and if else things.
11. No need to rm -rf %{buildroot} in %clean section.(RPM supports it since
long time ago, please change your habit)
12. No need to %defattr(-,root,root,-) (RPM supports it since long time ago,
please change your habit)
And:
%defattr(-,cubrid,cubrid,-)
%config(noreplace) %{_sysconfdir}/cubrid
%{cubridsharedata}/conf
%{cubridsharedata}/databases
%{cubridsharedata}/log
%{cubridsharedata}/tmp
%{cubridsharedata}/var
If you want to define your attributes, please use attr() in front of every file
you want to specify.
13. No need to keep BuildRoot tag(RPM supports it since long time ago, please
change your habit)
14. openjdk has 1.8 version now, please test.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fA5NKRg3TB&a=cc_unsubscribe
10 years, 9 months