[Bug 836821] New: Review Request: libcec - Library for HDMI-CEC device control
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=836821
Bug ID: 836821
QA Contact: extras-qa(a)fedoraproject.org
Severity: unspecified
Version: rawhide
Priority: unspecified
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org,
volker27(a)gmx.at
Assignee: nobody(a)fedoraproject.org
Summary: Review Request: libcec - Library for HDMI-CEC device
control
Regression: ---
Story Points: ---
Classification: Fedora
OS: Unspecified
Reporter: pbrobinson(a)gmail.com
Type: Bug
Documentation: ---
Hardware: Unspecified
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
CC: volker27(a)gmx.at
SPEC: http://pbrobinson.fedorapeople.org/libcec.spec
SRPM: http://pbrobinson.fedorapeople.org/libcec-1.7.1-1.fc17.src.rpm
Description:
libCEC allows you in combination with the right hardware to control your device
with your TV remote control. Utilising your existing HDMI cabling
libCEC is an enabling platform for the CEC bus in HDMI, it allows developers to
interact with other HDMI devices without having to worry about the
communication
overhead, handshaking, and the various ways of sending a message for each
vendor
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4211187
--- Comment #1 from Volker Fröhlich <volker27(a)gmx.at> ---
The license is GPLv2+, but it is actually dual-licensed:
* This program is dual-licensed; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
...
* Alternatively, you can license this library under a commercial license,
* please contact Pulse-Eight Licensing for more information.
The FSF address is outdated and should be replaced. Also let upstream know.
If this is a snapshot, the release should be different:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
The version number in the changelog also doesn't match.
Please add ?_isa, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Why do you require systemd-devel?
rpmlint complains about mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
1) and the non-american spelling of "utilizing". cec-config should be in the
main package.
defattr is no longer necessary. Consider to add ChangeLog as documentation.
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 3 months