[Bug 845934] New: Review Request: witty - C++ library for developing web applications
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845934
Bug ID: 845934
QA Contact: extras-qa(a)fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Assignee: nobody(a)fedoraproject.org
Summary: Review Request: witty - C++ library for developing web
applications
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: miminar(a)redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://minami.cz/public/witty.spec
SRPM URL: http://minami.cz/public/witty-3.2.1-1.fc16.src.rpm
Description:
Web C++ library with widget oriented API that uses well-tested patterns of
desktop GUI development tailored to the web. To the developer, it offers
abstraction of web-specific implementation details, including client-server
protocols, event handling, graphics support, graceful degradation (or
progressive enhancement), and URL handling.
Fedora Account System Username: miminar
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 6 months
[Bug 852914] Review Request: python-rackspace-monitoring - Client library for Rackspace Cloud Monitoring
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852914
Tomas Radej <tradej(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(bazanluis20@gmail
| |.com)
--- Comment #9 from Tomas Radej <tradej(a)redhat.com> ---
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX tarball generation or download is documented.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0 (rackspace-monitoring-0.3.1.tar.gz)
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[!]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Rpmlint
-------
Checking: python-rackspace-monitoring-0.3.1-5.fc19.noarch.rpm
python-rackspace-monitoring-0.3.1-5.fc19.src.rpm
python-rackspace-monitoring.src:17: W: mixed-use-of-spaces-and-tabs (spaces:
line 3, tab: line 17)
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
python-rackspace-monitoring-0.3.1-5.fc19.noarch.rpm (rpmlib, GLIBC filtered):
python(abi) = 2.7
Provides
--------
python-rackspace-monitoring-0.3.1-5.fc19.noarch.rpm:
python-rackspace-monitoring = 0.3.1-5.fc19
rackspace-monitoring = 0.3.1-5.fc19
MD5-sum check
-------------
http://pypi.python.org/packages/source/r/rackspace-monitoring/rackspace-m...
:
CHECKSUM(SHA256) this package :
0064e53f172c283ac8d81f02cf8b58595eda830835dd726d29e9776fa6fa9ea4
CHECKSUM(SHA256) upstream package :
0064e53f172c283ac8d81f02cf8b58595eda830835dd726d29e9776fa6fa9ea4
Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Command line :/usr/bin/fedora-review -b 852914 -m fedora-rawhide-x86_64
External plugins:
== Issues ==
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
>>>> Why is there the Provides for rackspace-monitoring? Unless there is a
>>>> good reason for it to be there, I am politely asking you to remove it.
== Notes ==
[!]: SHOULD %check is present and all tests pass.
>>>> As was said once before, upstream has a test dir. It would be nice to run
>>>> the tests.
[!]: Rpmlint output
>>>> It would be nice to replace the TAB on line 17 with spaces
*** NOT APPROVED *** until the question in Issues is resolved. Things in notes
are nice to have, but aren't crucial.
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 6 months
[Bug 747031] New: Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Summary: Review Request: ghc-hs-bibutils - Haskell bindings to
bibutils, the bibliography conversion utilities
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: unspecified
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: tpr(a)d5k.net
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Spec URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils.spec
SRPM URL:
http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils-4.12-0.fc15.src.rpm
rpmlint:
ghc-hs-bibutils.src: W: spelling-error %description -l en_US interconverts ->
inter converts, inter-converts, interconnects
ghc-hs-bibutils.src: W: spelling-error %description -l en_US http -> HTTP
ghc-hs-bibutils.src: W: spelling-error %description -l en_US www -> WWW, wow
ghc-hs-bibutils.src: W: spelling-error %description -l en_US scripps -> scrips,
scripts, scrimps
ghc-hs-bibutils.src: W: spelling-error %description -l en_US edu -> ed, educ,
due
ghc-hs-bibutils.src: W: spelling-error %description -l en_US cdputnam -> Putnam
ghc-hs-bibutils.src: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
ghc-hs-bibutils.src:74: W: macro-in-comment %define
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 6 months