It's no problem, I've fixed it with this.  The problems I was having went away with this change.

Brian

On Tue, Sep 14, 2010 at 2:53 PM, Andrew Brown <brownan@gmail.com> wrote:
ssh_tools, prov, and osutils should be updated if they're using the Opus logger. I was not in charge of those, although I should have checked. The opus logger itself uses the standard library logger, which does NOT use a PEP8 name and thus should stay getLogger(). Although the documentation within the log module should be updated to reflect the new usage.

Does that make sense? I forgot to check modules that I wasn't in charge of, and I forgot to update the documentation in opus.lib.log


On Tue, Sep 14, 2010 at 1:55 PM, Brian Bouterse <bmbouter@gmail.com> wrote:
The logger was recently rewritten and I want to make sure all the references using the old logger are updated.  I think there are some lingering things that weren't totally changed and I think are causing me some issues.  Basically during the logger rewrite, getLogger() was refactored into get_logger('nameoflogger') which means any lingering references to getLogger() should also be updated.  right?

When I grep for "getLogger" on all of opus I get:

[bmbouter@opus opus]$ grep -r "getLogger" ./
./lib/ssh_tools.py:log = opus.lib.log.getLogger()
./lib/osutils/windows.py:log = log.getLogger()
./lib/osutils/linux.py:log = log.getLogger()
./lib/osutils/__init__.py:log = log.getLogger()
./lib/log.py:Each application should get its own logger with the getLogger() function.  Here
./lib/log.py:>>> log = opus.lib.log.getLogger()
./lib/log.py:    opusroot = logging.getLogger("opus")
./lib/log.py:    applogger = logging.getLogger("opus."+name)
./lib/prov/deltacloud_old/log.py:log = logging.getLogger("deltacloud")

The entried in log.py are all documentation really, but what about the others?  Should I got through and update those?

Brian

--
Brian Bouterse
ITng Services

_______________________________________________
Opus-devel mailing list
Opus-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/opus-devel



_______________________________________________
Opus-devel mailing list
Opus-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/opus-devel




--
Brian Bouterse
ITng Services