----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to: - start a PAM session (for any user, root is fine) - authenticate *any* requests from polkit - authentication has been done on CIMOM level
Diffs -----
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/#review3138 -----------------------------------------------------------
Autoscan started for review(s) 1923[1]
- scanbot
On July 23, 2014, 11:24 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/
(Updated July 23, 2014, 11:24 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to:
- start a PAM session (for any user, root is fine)
- authenticate *any* requests from polkit
- authentication has been done on CIMOM level
Diffs
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/#review3144 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1923
- scanbot
On July 23, 2014, 11:24 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/
(Updated July 23, 2014, 11:24 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to:
- start a PAM session (for any user, root is fine)
- authenticate *any* requests from polkit
- authentication has been done on CIMOM level
Diffs
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/#review3145 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On July 23, 2014, 1:24 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/
(Updated July 23, 2014, 1:24 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to:
- start a PAM session (for any user, root is fine)
- authenticate *any* requests from polkit
- authentication has been done on CIMOM level
Diffs
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/#review3777 -----------------------------------------------------------
Pushing into devel/polkit branch and closing the review.
- Jan Safranek
On Čec. 23, 2014, 1:24 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/
(Updated Čec. 23, 2014, 1:24 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to:
- start a PAM session (for any user, root is fine)
- authenticate *any* requests from polkit
- authentication has been done on CIMOM level
Diffs
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1923/ -----------------------------------------------------------
(Updated Úno. 16, 2015, 3:28 odp.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to: - start a PAM session (for any user, root is fine) - authenticate *any* requests from polkit - authentication has been done on CIMOM level
Diffs -----
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher