----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/#review3105 -----------------------------------------------------------
Autoscan started for review(s) 1909[1]
- scanbot
On July 16, 2014, 8:06 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/
(Updated July 16, 2014, 8:06 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/#review3106 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On July 16, 2014, 10:06 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/
(Updated July 16, 2014, 10:06 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/#review3109 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1909
- scanbot
On July 16, 2014, 8:06 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/
(Updated July 16, 2014, 8:06 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/#review3778 -----------------------------------------------------------
Pushing into devel/polkit branch and closing the review.
- Jan Safranek
On Čec. 16, 2014, 10:06 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/
(Updated Čec. 16, 2014, 10:06 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1909/ -----------------------------------------------------------
(Updated Úno. 16, 2015, 3:28 odp.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264 src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org