On June 3, 2013, 8:24 a.m., Roman Rakus wrote:
> There are quite a lot of memory leaks when using
CMReturnWithChars macro. I would suggest to define new macro based on implementation of
CMReturnWithChars that will also free the "errmsg" string.
Let's wait for newer version of konkretcmpi -
https://bugzilla.redhat.com/show_bug.cgi?id=969494.
- Roman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/426/#review510
-----------------------------------------------------------
On May 31, 2013, 3:12 p.m., Roman Rakus wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/426/
-----------------------------------------------------------
(Updated May 31, 2013, 3:12 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Use asprintf instead of snprintf
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountManagementServiceProvider.c
1af6cf4f55f574d3bf665202ff7b55224a8d9009
src/account/LMI_AccountProvider.c 27be7e15f706b681cf07f83cec56fef2ccc7ecf5
src/account/LMI_AssignedAccountIdentityProvider.c
323a582217cd1c101863cc489b3e4ee94aa3a4ff
src/account/LMI_AssignedGroupIdentityProvider.c
a9037f1bd86a39ef21869796a692a0ec85affb08
src/account/LMI_GroupProvider.c a9c547724ecf8e66f92efb1677ee3b6f348f6051
src/account/LMI_IdentityProvider.c 92c2b0119a3dd81ca62be99c6e09f894f46841cd
src/account/LMI_MemberOfGroupProvider.c dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9
src/account/LMI_ServiceAffectsIdentityProvider.c
64e218b4068c696dbb5479d7e73c2f38b4fc0cb5
Diff:
http://reviewboard-openlmi.rhcloud.com/r/426/diff/
Testing
-------
Thanks,
Roman Rakus