----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3037 -----------------------------------------------------------
Autoscan failed: ~/system-management/scanbot/openlmi-providers ~/system-management/scanbot Already up-to-date. openlmi-providers-0.4.1_384_g1ea514b.tar.gz --2014-07-11 12:40:36-- https://reviewboard-openlmi.rhcloud.com/r/1893/diff/raw/ Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)... 23.22.105.178 Connecting to reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 19096 (19K) [text/x-patch] Saving to: '/tmp/tmp.cjJLifWyBy/1893.patch'
0K .......... ........ 100% 135K=0.1s
2014-07-11 12:40:37 (135 KB/s) - '/tmp/tmp.cjJLifWyBy/1893.patch' saved [19096/19096]
--2014-07-11 12:40:37-- https://reviewboard-openlmi.rhcloud.com/r/1891/diff/raw/ Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)... 23.22.105.178 Connecting to reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 22709 (22K) [text/x-patch] Saving to: '/tmp/tmp.cjJLifWyBy/1891.patch'
0K .......... .......... .. 100% 80.6K=0.3s
2014-07-11 12:40:38 (80.6 KB/s) - '/tmp/tmp.cjJLifWyBy/1891.patch' saved [22709/22709]
--2014-07-11 12:40:38-- https://reviewboard-openlmi.rhcloud.com/r/1892/diff/raw/ Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)... 23.22.105.178 Connecting to reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 2027 (2.0K) [text/x-patch] Saving to: '/tmp/tmp.cjJLifWyBy/1892.patch'
0K . 100% 31.0M=0s
2014-07-11 12:40:39 (31.0 MB/s) - '/tmp/tmp.cjJLifWyBy/1892.patch' saved [2027/2027]
error: line 429: Unclosed %if SRPM: Usage: covscan diff-build [options] <args>
covscan: error: please specify exactly one SRPM
- scanbot
On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 11, 2014, 10:31 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3045 -----------------------------------------------------------
Autoscan started for review(s) 1893[1], 1891[1], 1892[1]
- scanbot
On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 11, 2014, 10:31 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3047 -----------------------------------------------------------
Autoscan started for review(s) 1893[1], 1891[1], 1892[1]
- scanbot
On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 11, 2014, 10:31 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3052 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1891,1892,1893
- scanbot
On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 11, 2014, 10:31 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3056 -----------------------------------------------------------
Ship it!
The code looks sane, apart from combining C and C++ style comments. We should only use C-style comments.
cmake/modules/FindPAM.cmake http://reviewboard-openlmi.rhcloud.com/r/1891/#comment1699
Should "PAM" really be there twice?
- Jan Synacek
On July 11, 2014, 12:31 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 11, 2014, 12:31 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
On Čec. 14, 2014, 9:20 dop., Jan Synacek wrote:
cmake/modules/FindPAM.cmake, line 34 http://reviewboard-openlmi.rhcloud.com/r/1891/diff/1/?file=11086#file11086line34
Should "PAM" really be there twice?
Dunno, I just copied it from KDE :-)
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3056 -----------------------------------------------------------
On Čec. 11, 2014, 12:31 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated Čec. 11, 2014, 12:31 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/ -----------------------------------------------------------
(Updated Čec. 14, 2014, 1:50 odp.)
Review request for OpenLMI Developers.
Changes -------
- changed c++ comments to c - added logic from the bash script (see previous review) - removed unused code and includes - added polkit agent deregistration
Repository: openlmi-providers
Description (updated) -------
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs (updated) -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3079 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On July 14, 2014, 1:50 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated July 14, 2014, 1:50 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/#review3782 -----------------------------------------------------------
Pushing into devel/polkit branch and closing the review.
- Jan Safranek
On Čec. 14, 2014, 1:50 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/
(Updated Čec. 14, 2014, 1:50 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/ -----------------------------------------------------------
(Updated Úno. 16, 2015, 3:29 odp.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose. All the forks and execs were carefuly placed, don't change them without extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher