This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/ |
src/pcp/lmi/pcp/metric.py (Diff revision 2) | |||
---|---|---|---|
94 | raise pywbem.CIMError(pywbem.CIM_ERR_FAILED) |
Please add also description of the error, something like: raise pywbem.CIMError(pywbem.CIM_ERR_FAILED, "Unable to fetch data from PCP")
src/pcp/lmi/pcp/metric.py (Diff revision 2) | |||
---|---|---|---|
117 | except: |
"except" without defining the exception is considered bad habit in Python. It can easily hide programming mistakes and it even catches calling exit(). Please, specify which exceptions can occur
I don't consider these issues blockers, feel free to commit. Ask for the commit rights (gitcura group in fedora) if you don't have them. Or we can commit it for you.
- Radek Novacek
On July 9th, 2013, 4:09 a.m. CEST, Frank Eigler wrote:
Review request for OpenLMI Developers.
By Frank Eigler.
Updated July 9, 2013, 4:09 a.m.
Repository:
openlmi-providers
Description
Testing
Diffs
|