This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1487/

src/software/test/test_software_identity_file_check.py (Diff revision 1)
def do_check_symlink(self, pkg, filepath, inst):
168
            "Unexpected uid of modified symlink for %s:%s"%(
194
            "Unexpected uid of modified symlink for %s:%s", pkg.name, filepath)
This change looks weird, where are the '%s's expanded?

There are a lot of changes like this:
self.assert*(a, b, "error: %s != %s" % (a, b))
to
self.assert*(a, b, "error: %s != %s", a, b)

is it intentional? I didn't worked for me when I tried it.

- Radek Novacek


On January 23rd, 2014, 3:20 p.m. CET, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated Jan. 23, 2014, 3:20 p.m.

Repository: openlmi-providers

Description

software: added tests for non-ascii characters

Test that unicode characters work at least for package files.

Diffs

  • src/software/test/test_software_identity_file_check.py (6123d8c4e5f55e6912c0f7800054183e7a4e6dd7)
  • src/software/test/reposetup.py (c84e32cb54300b0245c3bc38461a8589627fdbe5)
  • src/software/test/test_software_identity_checks.py (b9d5fbbbc7795b496db52e82ffd95f9db0698460)

View Diff