This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1485/ |
On January 27th, 2014, 5:49 p.m. CET, Jan Safranek wrote:
src/lmi/storage/LMI_StorageConfigurationService.py (Diff revision 1) def cim_method_createormodifystoragepool(self, env, object_name,1107 if pool.type == 'lvmvg':1108 if param_inextents:1109 # modify vg
1110 self.cim_method_createormodifyvg(env, object_name,1111 param_elementname, param_goal,1112 param_inextents, param_pool,1113 input_arguments, method_name)1114 else:1115 # create thinpool
1116 self.cim_method_createormodifythinpool(env, object_name,1117 param_elementname, param_goal,1118 param_thinpool, None,1119 param_size)1120 if pool.type == 'lvmthinpool':1121 if param_inextents:1122 raise pywbem.CIMError(pywbem.CIM_ERR_NOT_SUPPORTED,1123 "InExtents specified together with Pool .")1124 else:1125 # modify thinpool
1126 self.cim_method_createormodifythinpool(env, object_name,1127 param_elementname, param_goal,1128 None, param_thinpool,1129 param_size)I think that goal.ThinProvisionedPoolType is _the_ property that decides, what caller wants to create/modify. If it is not specified -> default is used (create plain VG). If it is specified -> check the other options (InExtents, InPool) and throw error if there is unsupported combination (e.g. InExtents with ThinProvisionedPoolType = ThinlyProvisionedLimitlessStoragePool)On January 28th, 2014, 1:43 p.m. CET, Jan Synacek wrote:
What if the caller wants to create a thin pool without specifying a goal?
I _think_ it's not possible in SMI-S - if you don't specify goal, the default is used. And the default is plain VG.
- Jan
On January 23rd, 2014, 2:25 p.m. CET, Jan Synacek wrote:
Review request for OpenLMI Developers.
By Jan Synacek.
Updated Jan. 23, 2014, 2:25 p.m.
Repository:
openlmi-storage
Description
Diffs
|