This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1843/

On červen 30th, 2014, 1:30 odp. UTC, Peter Schiffer wrote:

again, class LMI_SoftwareMethodResult should be probably updated in 60_LMI_Software.mof file

That's right. Fixed.


On červen 30th, 2014, 1:30 odp. UTC, Peter Schiffer wrote:

src/software-dbus/LMI_SoftwareMethodResultProvider.c (Diff revision 1)
static CMPIStatus LMI_SoftwareMethodResultEnumInstances(
119
    {

why the newline before } ?

Seems more readable to me after multiline condition.


- Michal


On červenec 1st, 2014, 8:28 dop. UTC, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated Čec. 1, 2014, 8:28 dop.

Repository: openlmi-providers

Description

software-dbus: implemented LMI_SoftwareMethodResult

Diffs

  • mof/30_LMI_Jobs.mof (2bdb5265c4855ef36c0b9a0a5114b2fb14540f0e)
  • mof/60_LMI_Software.mof (b8611f307c2a2cbd9990d414b8b903ddeb4a31ba)
  • src/software-dbus/LMI_SoftwareMethodResultProvider.c (16830f6f14be9bed9e200fa71aa41b95d5083b0a)
  • src/software-dbus/sw-utils.h (94a3ff1afb8eeb55c37a1eb7bacf9dda65eb0907)

View Diff