This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1315/

cli/lmi/shell/LMIConnection.py (Diff revision 2)
def connect(uri, username="", password="", **kwargs):
150
        connection = LMIConnection(uri, username, password, interactive=interactive,
154
        connection = LMIConnection(uri, username, password, interactive=interactive,
151
            use_cache=use_cache, conn_type=LMIBaseClient.CONN_TYPE_WBEM,
155
            use_cache=use_cache, conn_type=LMIBaseClient.CONN_TYPE_WBEM,
152
            key_file=key_file, cert_file=cert_file, verify_server_cert=verify_server_cert)
156
            key_file=key_file, cert_file=cert_file, verify_server_cert=verify_server_cert)
153
        if not connection.verify_credentials():
157
        if not connection.verify_credentials():
158
            logger.error("Not connected, wrong username/password or certificate")
154
            return None
159
            return None
160
        else:
161
            logger.info("Connected to %s", uri)
What error is shown when the connection is refused or times out or returns other that 401 Unauthorized error?

- Jan Safranek


On December 2nd, 2013, 9:43 a.m. CET, Peter Hatina wrote:

Review request for OpenLMI Developers.
By Peter Hatina.

Updated Dec. 2, 2013, 9:43 a.m.

Repository: openlmi-tools

Description

The patch introduces some useful log messages in the connect() function. When connecting to CIMOM, 2 situations may occur:

1. user has provided valid username+password/certificate or is connected via Unix-socket:
   - in that case, output INFO message with "Connected" string
   - by default, lmishell outputs only ERROR messages, so no message will be print out
      - to see the message of successful connection, run lmishell with "-v" or "-m" CLI option

2. user has provided invalid username+password/certificate:
   - output ERROR message with "Not connected" string
   - the log message can be suppressed by running lmishell with "-q" CLI option

Diffs

  • cli/lmi/shell/LMIConnection.py (301fa520d8eacb39676af5e9ff479c3583df864e)
  • cli/lmishell (e493af571c72b9ffc22a500b6716d037faec88c3)

View Diff