This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/854/

src/account/test/testAccount.py (Diff revision 1)
67
        user = None
68
        user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)
69
        user.delete()
70
        self.assertFalse(user_exists(myuser))
What happened, when delete instance will fail and user remain in system?

src/account/test/testAccount.py (Diff revision 1)
74
        group.delete()
What happened when group deletion over lmi will fail?

src/account/test/testAccount.py (Diff revision 1)
98
            
Whitespaces.

src/account/test/testAccount.py (Diff revision 1)
99
            # delete user
100
            user = None
101
            user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)
102
            user.delete()
103
            self.assertFalse(user_exists(myuser))
104
105
            # delete group
106
            group = self.conn.root.cimv2.LMI_Group.first_instance(key="Name", value=myuser)
107
            group.delete()
108
            self.assertFalse(group_exists(myuser))
This should be part of tearDown()/cleanup phase which will be independend to lmi.

src/account/test/testAccount.py (Diff revision 1)
168
        # delete user
169
        user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)
170
        user.delete()
171
        self.assertFalse(user_exists(myuser))
172
173
       # delete group
174
        group = self.conn.root.cimv2.LMI_Group.first_instance(key="Name", value=mygroup)
175
        group.delete()
176
        self.assertFalse(group_exists(mygroup))
LMI independent code in cleanup phase please.

- Robin Hack


On September 12th, 2013, 9:33 a.m. UTC, Robin Hack wrote:

Review request for OpenLMI Developers.
By Robin Hack.

Updated Sept. 12, 2013, 9:33 a.m.

Repository: openlmi-providers

Description

Account: Added QA test for account provider.

Diffs

  • src/account/test/testAccount.py (PRE-CREATION)

View Diff